From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D98D91FF0B7 for ; Fri, 30 Oct 2026 14:25:42 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A30C921600; Fri, 30 Oct 2026 14:25:40 +0100 (CET) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-perl-rs v2 0/3] makefile: reduce ambiguity for targets: all/install/upload Date: Fri, 30 Oct 2026 14:25:30 +0100 Message-ID: <20261030132533.150795-1-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793366736275 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.455 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BX3U2ILMS6SAGVLIDNBMAQAKZK7EGSGB X-Message-ID-Hash: BX3U2ILMS6SAGVLIDNBMAQAKZK7EGSGB X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I encounted some minor inconsistencies in the Makefile: * make install only installs from release dir (Even though 'make all' generates a debug build per default) * File Fixup.pm is used inside a target but not specified as a prerequisite. * unsued variable for upload target. Some small patches to fix them. Not implemented --------------- Some minor fixes (such as replacing shell pwd with CURDIR) are not in this series, because they have already been address in this patch by Max: https://lore.proxmox.com/pve-devel/20260807090809.101155-1-m.carrara@proxmox.com/ Changes v1->v2 -------------- * fix typo in commit message of patch 2 * utilize UPLOAD_DIST variable in common/pkg/Makefile Previous versions: ------------------ v1: https://lore.proxmox.com/pve-devel/20261027104935.49190-1-e.huhsovitz@proxmox.com/ Summary of changes ------------------ Elias Huhsovitz (3): makefile: use TARGET_DIR variable for install target makefile: add Fixup.pm as prerequisite for $(BUILDDIR) makefile: use UPLOAD_DIST variable common/pkg/Makefile | 2 +- pmg-rs/Makefile | 8 ++++---- pve-rs/Makefile | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) -- 2.47.3