public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Rémi PAETA" <remi.paeta@comaite.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v2 1/2] network: do not fail on missing bridge fdb entries when migrating
Date: Thu, 29 Oct 2026 17:49:38 +0100	[thread overview]
Message-ID: <20261029164939.1278135-2-remi.paeta@comaite.com> (raw)
In-Reply-To: <20261029164939.1278135-1-remi.paeta@comaite.com>

del_nets_bridge_fdb() is called at the end of a live migration, to
remove the forwarding database entries of the NICs on the source
before the VM resumes on the target. If an entry is missing, for
example after a NIC got re-plugged (see bug #6490), 'bridge fdb del'
fails and so does the migration, after the VM state was transferred:
the VM stays paused and locked on the target, and the paused QEMU stays
on the source.

The source tap devices go away with the source QEMU anyway, so only
warn about entries that could not be deleted.

Suggested-by: Gabriel Goller <g.goller@proxmox.com>
Signed-off-by: Rémi PAETA <remi.paeta@comaite.com>
---
 src/PVE/QemuServer/Network.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer/Network.pm b/src/PVE/QemuServer/Network.pm
index b4893c01..01b21f86 100644
--- a/src/PVE/QemuServer/Network.pm
+++ b/src/PVE/QemuServer/Network.pm
@@ -309,7 +309,8 @@ sub del_nets_bridge_fdb {
         my $mac = $net->{macaddr} or next;
 
         my $bridge = $net->{bridge};
-        PVE::Network::SDN::Zones::del_bridge_fdb($iface, $mac, $bridge);
+        eval { PVE::Network::SDN::Zones::del_bridge_fdb($iface, $mac, $bridge) };
+        log_warn("failed to delete forwarding database entries of '$iface' - $@") if $@;
     }
 }
 
-- 
2.47.3




  reply	other threads:[~2026-10-29 16:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 16:49 [PATCH qemu-server v2 0/2] fix #6490: network: bridge fdb entries on nic hotplug Rémi PAETA
2026-10-29 16:49 ` Rémi PAETA [this message]
2026-10-29 16:49 ` [PATCH qemu-server v2 2/2] fix #6490: network: add bridge fdb entries when hotplugging a nic Rémi PAETA
2026-10-30 13:32 ` [PATCH qemu-server v2 0/2] fix #6490: network: bridge fdb entries on nic hotplug Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029164939.1278135-2-remi.paeta@comaite.com \
    --to=remi.paeta@comaite.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal