From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0A7431FF0BC for ; Thu, 29 Oct 2026 17:49:55 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A169F2141B; Thu, 29 Oct 2026 17:49:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.10.3 smtp.infra.comaite.com 5E6CD62C03 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comaite.com; s=377A38C6-3A8D-11E5-A0EC-E97757B27CB3; t=1793292579; bh=zKohPjVo58hxWZwq8o2BoR0lyYVx5hwQjd2UhNdcoHE=; h=From:To:Date:Message-ID:MIME-Version; b=iaZrkqpxcxxzumLxarP7UUR9F5Sd6BIbJrgMCuOz8ElEG+joMZ48N+d82zWnaJK/c g6wt3IvIyVLF0pebMGuLMkk3rJL4EzgO97S4Ajl1Tvlxmwm/0tcvIHbVt4/r4am8KE usvWdRd536RMvFd9CtIF92R9/vzLdAmWU8o2qrzYn+girfTzXEQybPhL/ZANADqW+s 0PSnRXzXIMHlYNijzwKyLXOfI804JohrYaVbULwmmfcjsv8ZoiLpJPP8QfQrf03AVs LNwHk+/eqqJq8wMrmAAgMDgwdt4u6wfcKrzlMGirZxCQb6Urb3sgLI2FWTzNdDsA3m +WCSo72JFQ31g== From: =?UTF-8?q?R=C3=A9mi=20PAETA?= To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 1/2] network: do not fail on missing bridge fdb entries when migrating Date: Thu, 29 Oct 2026 17:49:38 +0100 Message-ID: <20261029164939.1278135-2-remi.paeta@comaite.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261029164939.1278135-1-remi.paeta@comaite.com> References: <20261029164939.1278135-1-remi.paeta@comaite.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.250 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DVILHAJIRCSAX4LKGEW324TAR76U6TMN X-Message-ID-Hash: DVILHAJIRCSAX4LKGEW324TAR76U6TMN X-MailFrom: remi.paeta@comaite.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: del_nets_bridge_fdb() is called at the end of a live migration, to remove the forwarding database entries of the NICs on the source before the VM resumes on the target. If an entry is missing, for example after a NIC got re-plugged (see bug #6490), 'bridge fdb del' fails and so does the migration, after the VM state was transferred: the VM stays paused and locked on the target, and the paused QEMU stays on the source. The source tap devices go away with the source QEMU anyway, so only warn about entries that could not be deleted. Suggested-by: Gabriel Goller Signed-off-by: Rémi PAETA --- src/PVE/QemuServer/Network.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuServer/Network.pm b/src/PVE/QemuServer/Network.pm index b4893c01..01b21f86 100644 --- a/src/PVE/QemuServer/Network.pm +++ b/src/PVE/QemuServer/Network.pm @@ -309,7 +309,8 @@ sub del_nets_bridge_fdb { my $mac = $net->{macaddr} or next; my $bridge = $net->{bridge}; - PVE::Network::SDN::Zones::del_bridge_fdb($iface, $mac, $bridge); + eval { PVE::Network::SDN::Zones::del_bridge_fdb($iface, $mac, $bridge) }; + log_warn("failed to delete forwarding database entries of '$iface' - $@") if $@; } } -- 2.47.3