public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v4 26/27] ui: firewall: show the task for reference updates
Date: Thu, 22 Oct 2026 14:47:07 +0200	[thread overview]
Message-ID: <20261022124708.429069-27-a.bied-charreton@proxmox.com> (raw)
In-Reply-To: <20261022124708.429069-1-a.bied-charreton@proxmox.com>

Renaming or deleting an ipset or alias returns a UPID. Open the task
progress window and reload the grid once the task has finished.

Both dialogs only open that window if a UPID is returned, so the
requests that are still answered synchronously (a plain create or an
edit that only changes a comment) are not affected.

Also add display names for the four task types.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/Utils.js                     | 4 ++++
 www/manager6/grid/FirewallAliases.js      | 4 ++++
 www/manager6/grid/FirewallObjectCommon.js | 2 ++
 www/manager6/panel/IPSet.js               | 4 ++++
 4 files changed, 14 insertions(+)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 8b99371d..9ec3951a 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -2194,6 +2194,10 @@ Ext.define('PVE.Utils', {
             dircreate: [gettext('Directory Storage'), gettext('Create')],
             dirremove: [gettext('Directory'), gettext('Remove')],
             download: [gettext('File'), gettext('Download')],
+            'fw-alias-delete': [gettext('Firewall Alias'), gettext('Delete')],
+            'fw-alias-rename': [gettext('Firewall Alias'), gettext('Rename')],
+            'fw-ipset-delete': [gettext('Firewall IPSet'), gettext('Delete')],
+            'fw-ipset-rename': [gettext('Firewall IPSet'), gettext('Rename')],
             hamigrate: ['HA', gettext('Migrate')],
             hashutdown: ['HA', gettext('Shutdown')],
             hastart: ['HA', gettext('Start')],
diff --git a/www/manager6/grid/FirewallAliases.js b/www/manager6/grid/FirewallAliases.js
index 06dc3b9c..de8a92eb 100644
--- a/www/manager6/grid/FirewallAliases.js
+++ b/www/manager6/grid/FirewallAliases.js
@@ -7,6 +7,9 @@ Ext.define('PVE.FirewallAliasEdit', {
 
     width: 400,
 
+    // a rename that updates references comes back as a task
+    showProgress: true,
+
     onlineHelp: 'pve_firewall_dangling_references',
 
     initComponent: function () {
@@ -242,6 +245,7 @@ Ext.define('PVE.FirewallAliases', {
                         },
                     ],
                     apiCallDone: reload,
+                    taskDone: reload,
                 }).show();
             },
         });
diff --git a/www/manager6/grid/FirewallObjectCommon.js b/www/manager6/grid/FirewallObjectCommon.js
index 04dddf48..0b912650 100644
--- a/www/manager6/grid/FirewallObjectCommon.js
+++ b/www/manager6/grid/FirewallObjectCommon.js
@@ -4,6 +4,8 @@ Ext.define('PVE.window.FirewallObjectRemove', {
 
     width: 500,
 
+    showProgress: true,
+
     // [{ value, text, description }, ...]
     referenceActions: undefined,
 
diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index 40c1ef4b..b2438ce1 100644
--- a/www/manager6/panel/IPSet.js
+++ b/www/manager6/panel/IPSet.js
@@ -125,7 +125,10 @@ Ext.define('PVE.IPSetList', {
                 url: me.base_url,
                 method: 'POST',
                 digest: rec.data.digest,
+                // a rename that updates references comes back as a task
+                showProgress: true,
                 onlineHelp: 'pve_firewall_dangling_references',
+
                 items: [ipanel],
             });
             win.show();
@@ -201,6 +204,7 @@ Ext.define('PVE.IPSetList', {
                         },
                     ],
                     apiCallDone: reload,
+                    taskDone: reload,
                 }).show();
             },
         });
-- 
2.47.3





  parent reply	other threads:[~2026-10-22 12:50 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 12:46 [PATCH container/docs/firewall/manager/network/qemu-server v4 00/27] handle dangling references when firewall objects go away Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 01/27] firewall: move object reference helpers to their own module Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 02/27] firewall: references: add helpers to update object references Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 03/27] firewall: references: log the references an object update touched Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 04/27] firewall: references: add wrappers for the SDN-generated IPSets Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 05/27] firewall: parser: do not log errors for disabled rules Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 06/27] firewall: ipset: add option to handle dangling references on rename Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 07/27] firewall: ipset: add option to handle dangling references on delete Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 08/27] firewall: aliases: add option to handle dangling references on rename Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 09/27] firewall: aliases: add option to handle dangling references on delete Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 10/27] firewall: api: run reference updates as tasks Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 11/27] firewall: tests: add tests for object reference updates Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 12/27] firewall: references: handle security groups Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 13/27] firewall: groups: add option to handle dangling references on rename Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-firewall v4 14/27] fix #8176: firewall: groups: handle dangling references on delete Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-network v4 15/27] apply: add option to handle dangling references on VNet deletion Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH qemu-server v4 16/27] api: destroy_vm: add option to handle dangling IPSet references Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-container v4 17/27] " Arthur Bied-Charreton
2026-10-22 12:46 ` [PATCH pve-docs v4 18/27] firewall: remove trailing spaces Arthur Bied-Charreton
2026-10-22 12:47 ` [PATCH pve-docs v4 19/27] firewall: document renaming and removing objects Arthur Bied-Charreton
2026-10-22 12:47 ` [PATCH pve-manager v4 20/27] ui: firewall: add a common widget for handling dangling references Arthur Bied-Charreton
2026-10-22 12:47 ` [PATCH pve-manager v4 21/27] ui: firewall: ipset: add controls for " Arthur Bied-Charreton
2026-10-22 12:47 ` [PATCH pve-manager v4 22/27] ui: firewall: aliases: " Arthur Bied-Charreton
2026-10-22 12:47 ` [PATCH pve-manager v4 23/27] ui: sdn: apply: add control for dangling IPSet references Arthur Bied-Charreton
2026-10-22 12:47 ` [PATCH pve-manager v4 24/27] ui: guest destroy: use let for non-constant variable bindings Arthur Bied-Charreton
2026-10-22 12:47 ` [PATCH pve-manager v4 25/27] ui: guest destroy: add control for dangling IPSet references Arthur Bied-Charreton
2026-10-22 12:47 ` Arthur Bied-Charreton [this message]
2026-10-22 12:47 ` [PATCH pve-manager v4 27/27] ui: firewall: groups: add controls for dangling references Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022124708.429069-27-a.bied-charreton@proxmox.com \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal