[PATCH pve-manager v4 25/27] ui: guest destroy: add control for dangling IPSet references

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

Destroying a guest releases its IPAM entries, so the auto-generated
'guest-ipam-<vmid>' IPSet disappears as well. Rules referencing that
IPSet do not resolve anymore and are dropped from the generated ruleset
as a result.

Add the shared selector to the destroy dialog, so those rules can be
disabled or deleted along with the guest, and a hint linking to the
SDN firewall integration documentation.

The 'note' config only renders a single hint, so it is replaced by
two display fields among the additional items.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/window/SafeDestroyGuest.js | 65 ++++++++++++++++++++++++-
 1 file changed, 64 insertions(+), 1 deletion(-)

diff --git a/www/manager6/window/SafeDestroyGuest.js b/www/manager6/window/SafeDestroyGuest.js
index 45b277e5..536bfc6a 100644
--- a/www/manager6/window/SafeDestroyGuest.js
+++ b/www/manager6/window/SafeDestroyGuest.js
@@ -1,6 +1,11 @@
 /*
  * SafeDestroy window with additional checkboxes for removing guests
  */
+// scanned by asciidoc-pve, so the anchor lands in the documentation index
+const GUEST_IPAM_IPSET_HELP = {
+    onlineHelp: 'pve_firewall_automatically_generated_ipsets',
+};
+
 Ext.define('PVE.window.SafeDestroyGuest', {
     extend: 'Proxmox.window.SafeDestroy',
     alias: 'widget.pveSafeDestroyGuest',
@@ -32,7 +37,62 @@ Ext.define('PVE.window.SafeDestroyGuest', {
         },
     ],
 
-    note: gettext('Referenced disks will always be destroyed.'),
+    initComponent: function () {
+        let me = this;
+
+        let helpLink = Ext.htmlEncode(
+            Proxmox.Utils.get_help_link(GUEST_IPAM_IPSET_HELP.onlineHelp),
+        );
+        let helpLabel = Ext.htmlEncode(gettext("this guest's auto-generated IPSet"));
+        let refsHint = Ext.String.format(
+            gettext('Firewall rules referencing {0} will no longer resolve.'),
+            `<a target="_blank" href="${helpLink}">${helpLabel}</a>`,
+        );
+
+        me.additionalItems = [
+            // pushing would append on every open
+            ...me.additionalItems,
+            {
+                xtype: 'displayfield',
+                userCls: 'pmx-hint',
+                value: gettext('Referenced disks will always be destroyed.'),
+            },
+            {
+                xtype: 'pveFirewallReferenceAction',
+                reference: 'firewallDanglingReferencesButton',
+                name: 'dangling-ipset-references',
+                preferredValue: 'drop',
+                fieldLabel: gettext('Referencing rules'),
+                labelWidth: 200,
+                referenceActions: [
+                    {
+                        text: gettext('Keep'),
+                        value: 'keep',
+                        description: gettext(
+                            "Do not touch firewall rules referencing this guest's IPAM IPSet.",
+                        ),
+                    },
+                    {
+                        text: gettext('Disable'),
+                        value: 'disable',
+                        description: gettext("Disable firewall rules referencing this guest's IPAM IPSet."),
+                    },
+                    {
+                        text: gettext('Delete'),
+                        value: 'drop',
+                        description: gettext("Delete firewall rules referencing this guest's IPAM IPSet."),
+                    },
+                ],
+            },
+            {
+                xtype: 'displayfield',
+                userCls: 'pmx-hint',
+                value: refsHint,
+            },
+        ];
+
+        me.callParent();
+    },
 
     getParams: function () {
         let me = this;
@@ -43,6 +103,9 @@ Ext.define('PVE.window.SafeDestroyGuest', {
         let destroyUnreferencedCheckbox = me.lookupReference('destroyUnreferencedCheckbox');
         me.params['destroy-unreferenced-disks'] = destroyUnreferencedCheckbox.checked ? 1 : 0;
 
+        let danglingRefs = me.lookupReference('firewallDanglingReferencesButton');
+        me.params['dangling-ipset-references'] = danglingRefs.getValue();
+
         return me.callParent();
     },
 });
-- 
2.47.3