[PATCH container] lxc: remove unused find_lxc_console_pids helper

[PATCH container] lxc: remove unused find_lxc_console_pids helper

[Filip Schauer]

The helper is no longer needed, as its only user was the stale LXC
console reaper in pve-manager, which was removed in
888c136dd303 ("fix #8093: pvestatd: remove stale lxc console reaper").

Drop the now dead code.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 src/PVE/LXC.pm | 30 ------------------------------
 1 file changed, 30 deletions(-)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 65a04a4..9c6b3d3 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -414,36 +414,6 @@ sub vmstatus {
     return $list;
 }
 
-sub find_lxc_console_pids {
-
-    my $res = {};
-
-    PVE::Tools::dir_glob_foreach(
-        '/proc',
-        '\d+',
-        sub {
-            my ($pid) = @_;
-
-            my $cmdline = PVE::Tools::file_read_firstline("/proc/$pid/cmdline");
-            return if !$cmdline;
-
-            my @args = split(/\0/, $cmdline);
-
-            # search for lxc-console -n <vmid>
-            return if scalar(@args) != 3;
-            return if $args[1] ne '-n';
-            return if $args[2] !~ m/^\d+$/;
-            return if $args[0] !~ m|^(/usr/bin/)?lxc-console$|;
-
-            my $vmid = $args[2];
-
-            push @{ $res->{$vmid} }, $pid;
-        },
-    );
-
-    return $res;
-}
-
 sub find_lxc_pid {
     my ($vmid) = @_;
 
-- 
2.47.3

Re: [PATCH container] lxc: remove unused find_lxc_console_pids helper

[Filip Schauer]

This should only be applied once pve-manager is bumped to 9.2.22 or
whatever the next version ends up being.

We should also add the following to pve-container/debian/control:
```
Breaks: pve-manager (<< 9.2.22)
```

On 15/10/2026 14:06, Filip Schauer wrote:
> The helper is no longer needed, as its only user was the stale LXC
> console reaper in pve-manager, which was removed in
> 888c136dd303 ("fix #8093: pvestatd: remove stale lxc console reaper").
> 
> Drop the now dead code.
> 
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
>   src/PVE/LXC.pm | 30 ------------------------------
>   1 file changed, 30 deletions(-)
> 
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 65a04a4..9c6b3d3 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -414,36 +414,6 @@ sub vmstatus {
>       return $list;
>   }
>   
> -sub find_lxc_console_pids {
> -
> -    my $res = {};
> -
> -    PVE::Tools::dir_glob_foreach(
> -        '/proc',
> -        '\d+',
> -        sub {
> -            my ($pid) = @_;
> -
> -            my $cmdline = PVE::Tools::file_read_firstline("/proc/$pid/cmdline");
> -            return if !$cmdline;
> -
> -            my @args = split(/\0/, $cmdline);
> -
> -            # search for lxc-console -n <vmid>
> -            return if scalar(@args) != 3;
> -            return if $args[1] ne '-n';
> -            return if $args[2] !~ m/^\d+$/;
> -            return if $args[0] !~ m|^(/usr/bin/)?lxc-console$|;
> -
> -            my $vmid = $args[2];
> -
> -            push @{ $res->{$vmid} }, $pid;
> -        },
> -    );
> -
> -    return $res;
> -}
> -
>   sub find_lxc_pid {
>       my ($vmid) = @_;
>