public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v3 8/8] hotplug: name the missing bridge in the error message
Date: Wed,  7 Oct 2026 16:18:00 +0200	[thread overview]
Message-ID: <20261007142145.984970-9-d.csapak@proxmox.com> (raw)
In-Reply-To: <20261007142145.984970-1-d.csapak@proxmox.com>

This makes it easier to find out which bridge is missing when
hotplugging a device fails.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/PVE/QemuServer.pm                     | 2 +-
 src/test/hotplug/disk-add-scsi14-old.conf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 2a55d970..7e5f7bbb 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -4194,7 +4194,7 @@ sub assert_pci_bridge_present {
     my $devices_list = vm_devices_list($vmid);
 
     if (!defined($devices_list->{$bridge})) {
-        die "can't hotplug bridge necessary for '$device'\n";
+        die "can't hotplug bridge '$bridge' necessary for '$device'\n";
     }
 
     return 1;
diff --git a/src/test/hotplug/disk-add-scsi14-old.conf b/src/test/hotplug/disk-add-scsi14-old.conf
index febda9da..f2f6775d 100644
--- a/src/test/hotplug/disk-add-scsi14-old.conf
+++ b/src/test/hotplug/disk-add-scsi14-old.conf
@@ -1,5 +1,5 @@
 # TEST: hotplugging a SCSI disk whose new LSI controller needs a hotplugged PCI bridge fails on QEMU < 11.1
-# EXPECTED_ERROR: scsi14: hotplug problem - can't hotplug bridge necessary for 'scsihw2'
+# EXPECTED_ERROR: scsi14: hotplug problem - can't hotplug bridge 'pci.4' necessary for 'scsihw2'
 # STAYS_PENDING: 1
 bootdisk: scsi0
 cores: 2
-- 
2.47.3





      parent reply	other threads:[~2026-10-07 14:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 14:17 [PATCH qemu-server v3 0/8] add hotplug tests and fix uncovered bugs Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 1/8] tests: hotplug: add initial hotplug test harness Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 2/8] tests: hotplug: add some test cases Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 3/8] tests: hotplug: add test case for adding scsi14 on qemu 11.1 Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 4/8] tests: hotplug: add cases for known defects Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 5/8] hotplug: fix hot unplugging tablet on aarch64 Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 6/8] hotplug: fix vm_deviceplug call for 'tablet' and 'keyboard' " Dominik Csapak
2026-10-07 14:17 ` [PATCH qemu-server v3 7/8] hotplug: remove iothread if adding drive device failed Dominik Csapak
2026-10-07 14:18 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261007142145.984970-9-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal