From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 98D2F1FF0AB for ; Wed, 07 Oct 2026 16:22:17 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0D2A921666; Wed, 07 Oct 2026 16:21:52 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v3 8/8] hotplug: name the missing bridge in the error message Date: Wed, 7 Oct 2026 16:18:00 +0200 Message-ID: <20261007142145.984970-9-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261007142145.984970-1-d.csapak@proxmox.com> References: <20261007142145.984970-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.382 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3JMP4WSIGHVSV3QKYVEFSDYWVZL4PIF3 X-Message-ID-Hash: 3JMP4WSIGHVSV3QKYVEFSDYWVZL4PIF3 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This makes it easier to find out which bridge is missing when hotplugging a device fails. Signed-off-by: Dominik Csapak --- src/PVE/QemuServer.pm | 2 +- src/test/hotplug/disk-add-scsi14-old.conf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 2a55d970..7e5f7bbb 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -4194,7 +4194,7 @@ sub assert_pci_bridge_present { my $devices_list = vm_devices_list($vmid); if (!defined($devices_list->{$bridge})) { - die "can't hotplug bridge necessary for '$device'\n"; + die "can't hotplug bridge '$bridge' necessary for '$device'\n"; } return 1; diff --git a/src/test/hotplug/disk-add-scsi14-old.conf b/src/test/hotplug/disk-add-scsi14-old.conf index febda9da..f2f6775d 100644 --- a/src/test/hotplug/disk-add-scsi14-old.conf +++ b/src/test/hotplug/disk-add-scsi14-old.conf @@ -1,5 +1,5 @@ # TEST: hotplugging a SCSI disk whose new LSI controller needs a hotplugged PCI bridge fails on QEMU < 11.1 -# EXPECTED_ERROR: scsi14: hotplug problem - can't hotplug bridge necessary for 'scsihw2' +# EXPECTED_ERROR: scsi14: hotplug problem - can't hotplug bridge 'pci.4' necessary for 'scsihw2' # STAYS_PENDING: 1 bootdisk: scsi0 cores: 2 -- 2.47.3