[PATCH pve-storage 2/2] esxi: rewrite non-UTF-8 password files

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

Before the previous commit, passwords containing characters in the
U+0080 to U+00FF range were written as Latin-1, whcih listvms.py and the
FUSE tool choked on. Existing storages would keep failing until their
password was set again.

The old code wrote each such character as a single byte, so a password
file that is not valid UTF-8 can only be Latin-1. Before querying the
host, rewrite such a file as UTF-8, which recovers the original password
exactly.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 src/PVE/Storage/ESXiPlugin.pm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index 7defb7b..3c0c9e3 100644
--- a/src/PVE/Storage/ESXiPlugin.pm
+++ b/src/PVE/Storage/ESXiPlugin.pm
@@ -147,6 +147,13 @@ sub get_manifest : prototype($$$;$) {
     my $host = $scfg->{server};
     my $user = $scfg->{username};
     my $pwfile = esxi_cred_file_name($storeid);
+
+    # migrate pre-existing passwords affected by #7360
+    if (-e $pwfile) {
+        my $pw = file_get_contents($pwfile);
+        esxi_set_credentials($pw, $storeid) if !utf8::decode(my $tmp = $pw);
+    }
+
     my $json = '';
     my $errmsg = '';
     eval {
-- 
2.47.3