From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id CC37D1FF09C for ; Mon, 05 Oct 2026 13:03:40 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 81B7F2159D; Mon, 05 Oct 2026 13:03:32 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage 2/2] esxi: rewrite non-UTF-8 password files Date: Mon, 5 Oct 2026 12:55:23 +0200 Message-ID: <20261005110306.2197624-3-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261005110306.2197624-1-a.bied-charreton@proxmox.com> References: <20261005110306.2197624-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791198208572 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.059 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5CLDU7LEGDALWGLX4LWKRPVW35GVIUDZ X-Message-ID-Hash: 5CLDU7LEGDALWGLX4LWKRPVW35GVIUDZ X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Before the previous commit, passwords containing characters in the U+0080 to U+00FF range were written as Latin-1, whcih listvms.py and the FUSE tool choked on. Existing storages would keep failing until their password was set again. The old code wrote each such character as a single byte, so a password file that is not valid UTF-8 can only be Latin-1. Before querying the host, rewrite such a file as UTF-8, which recovers the original password exactly. Signed-off-by: Arthur Bied-Charreton --- src/PVE/Storage/ESXiPlugin.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index 7defb7b..3c0c9e3 100644 --- a/src/PVE/Storage/ESXiPlugin.pm +++ b/src/PVE/Storage/ESXiPlugin.pm @@ -147,6 +147,13 @@ sub get_manifest : prototype($$$;$) { my $host = $scfg->{server}; my $user = $scfg->{username}; my $pwfile = esxi_cred_file_name($storeid); + + # migrate pre-existing passwords affected by #7360 + if (-e $pwfile) { + my $pw = file_get_contents($pwfile); + esxi_set_credentials($pw, $storeid) if !utf8::decode(my $tmp = $pw); + } + my $json = ''; my $errmsg = ''; eval { -- 2.47.3