* [PATCH manager] ui: qemu pci edit: remove the default PCI domain again before saving
@ 2026-10-04 16:34 Michal Fox
0 siblings, 0 replies; only message in thread
From: Michal Fox @ 2026-10-04 16:34 UTC (permalink / raw)
To: pve-devel
The PCI selector shows the IDs of the devices including the domain, so
the default '0000' domain was removed again before saving, as it is
optional in the hostpci option.
Since the refactoring in commit a7ec3666 ("ui: qemu/PCI Edit: code
cleanup/refactoring/modernize"), the result of the replace call is not
assigned anymore, so the domain is kept and a device that was
configured as '01:00.0' gets saved as '0000:01:00.0' on any edit of
the passthrough device.
Assign the result again, so the domain is only kept if it is not the
default one, like before.
Fixes: a7ec3666 ("ui: qemu/PCI Edit: code cleanup/refactoring/modernize")
Signed-off-by: Michal Fox <me@dualfroz.com>
---
Tested in the browser with the PCI edit window and mocked configs:
'hostpci0: 01:00.0' is saved as '01:00.0' again instead of
'0000:01:00.0', while a device in another domain like '0001:02:00.0'
and mapped devices are saved as before.
www/manager6/qemu/PCIEdit.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
index 4e8ed744..52f92c27 100644
--- a/www/manager6/qemu/PCIEdit.js
+++ b/www/manager6/qemu/PCIEdit.js
@@ -109,7 +109,9 @@ Ext.define('PVE.qemu.PCIInputPanel', {
// FIXME: what if no confid was found??
}
- values.host?.replace(/^0000:/, ''); // remove optional '0000' domain
+ if (values.host) {
+ values.host = values.host.replace(/^0000:/, ''); // remove optional '0000' domain
+ }
if (values.multifunction && values.host) {
values.host = values.host.substring(0, values.host.indexOf('.')); // skip the '.X'
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-10-04 16:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-04 16:34 [PATCH manager] ui: qemu pci edit: remove the default PCI domain again before saving Michal Fox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox