public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox-ve-rs] proxmox-frr: add missing build-deps proxmox-frr-templates
@ 2026-10-04 10:11 Luke Yasuda
  2026-10-05  8:56 ` Gabriel Goller
  2026-10-05 11:05 ` applied: " Fabian Grünbichler
  0 siblings, 2 replies; 3+ messages in thread
From: Luke Yasuda @ 2026-10-04 10:11 UTC (permalink / raw)
  To: pve-devel; +Cc: Luke Yasuda

It fails on tests without proxmox-frr-templates.

Signed-off-by: Luke Yasuda <jing@jing.rocks>
---
I have to admit that I don't know much about rust or rust packaging...
But congratulations on migrating from mailman2 to mailman3! Although
I can't find where is the mailing list archive. I'm not subscribed to
this list.
---
 proxmox-frr/debian/control       | 3 ++-
 proxmox-frr/debian/debcargo.toml | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/proxmox-frr/debian/control b/proxmox-frr/debian/control
index b118bec..1436baf 100644
--- a/proxmox-frr/debian/control
+++ b/proxmox-frr/debian/control
@@ -19,7 +19,8 @@ Build-Depends-Arch: cargo:native <!nocheck>,
  librust-serde-1+derive-dev <!nocheck>,
  librust-serde-repr-0.1+default-dev <!nocheck>,
  librust-thiserror-2+default-dev <!nocheck>,
- librust-tracing-0.1+default-dev <!nocheck>
+ librust-tracing-0.1+default-dev <!nocheck>,
+ proxmox-frr-templates <!nocheck>,
 Maintainer: Proxmox Support Team <support@proxmox.com>
 Standards-Version: 4.7.2
 Vcs-Git: git://git.proxmox.com/git/proxmox-ve-rs.git
diff --git a/proxmox-frr/debian/debcargo.toml b/proxmox-frr/debian/debcargo.toml
index 87a787e..d427d2c 100644
--- a/proxmox-frr/debian/debcargo.toml
+++ b/proxmox-frr/debian/debcargo.toml
@@ -5,3 +5,4 @@ maintainer = "Proxmox Support Team <support@proxmox.com>"
 [source]
 vcs_git = "git://git.proxmox.com/git/proxmox-ve-rs.git"
 vcs_browser = "https://git.proxmox.com/?p=proxmox-ve-rs.git"
+build_depends = ["proxmox-frr-templates"]
-- 
2.55.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH proxmox-ve-rs] proxmox-frr: add missing build-deps proxmox-frr-templates
  2026-10-04 10:11 [PATCH proxmox-ve-rs] proxmox-frr: add missing build-deps proxmox-frr-templates Luke Yasuda
@ 2026-10-05  8:56 ` Gabriel Goller
  2026-10-05 11:05 ` applied: " Fabian Grünbichler
  1 sibling, 0 replies; 3+ messages in thread
From: Gabriel Goller @ 2026-10-05  8:56 UTC (permalink / raw)
  To: Luke Yasuda; +Cc: pve-devel

On 04.10.2026 19:11, Luke Yasuda wrote:
> It fails on tests without proxmox-frr-templates.
> 
> Signed-off-by: Luke Yasuda <jing@jing.rocks>
> ---
> I have to admit that I don't know much about rust or rust packaging...
> But congratulations on migrating from mailman2 to mailman3! Although
> I can't find where is the mailing list archive. I'm not subscribed to
> this list.
> ---
>  proxmox-frr/debian/control       | 3 ++-
>  proxmox-frr/debian/debcargo.toml | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)

LGTM, what do you think @Fabian?

> diff --git a/proxmox-frr/debian/control b/proxmox-frr/debian/control
> index b118bec..1436baf 100644
> --- a/proxmox-frr/debian/control
> +++ b/proxmox-frr/debian/control
> @@ -19,7 +19,8 @@ Build-Depends-Arch: cargo:native <!nocheck>,
>   librust-serde-1+derive-dev <!nocheck>,
>   librust-serde-repr-0.1+default-dev <!nocheck>,
>   librust-thiserror-2+default-dev <!nocheck>,
> - librust-tracing-0.1+default-dev <!nocheck>
> + librust-tracing-0.1+default-dev <!nocheck>,
> + proxmox-frr-templates <!nocheck>,
>  Maintainer: Proxmox Support Team <support@proxmox.com>
>  Standards-Version: 4.7.2
>  Vcs-Git: git://git.proxmox.com/git/proxmox-ve-rs.git
> diff --git a/proxmox-frr/debian/debcargo.toml b/proxmox-frr/debian/debcargo.toml
> index 87a787e..d427d2c 100644
> --- a/proxmox-frr/debian/debcargo.toml
> +++ b/proxmox-frr/debian/debcargo.toml
> @@ -5,3 +5,4 @@ maintainer = "Proxmox Support Team <support@proxmox.com>"
>  [source]
>  vcs_git = "git://git.proxmox.com/git/proxmox-ve-rs.git"
>  vcs_browser = "https://git.proxmox.com/?p=proxmox-ve-rs.git"
> +build_depends = ["proxmox-frr-templates"]
> -- 
> 2.55.0
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 3+ messages in thread

* applied: [PATCH proxmox-ve-rs] proxmox-frr: add missing build-deps proxmox-frr-templates
  2026-10-04 10:11 [PATCH proxmox-ve-rs] proxmox-frr: add missing build-deps proxmox-frr-templates Luke Yasuda
  2026-10-05  8:56 ` Gabriel Goller
@ 2026-10-05 11:05 ` Fabian Grünbichler
  1 sibling, 0 replies; 3+ messages in thread
From: Fabian Grünbichler @ 2026-10-05 11:05 UTC (permalink / raw)
  To: pve-devel, Luke Yasuda


On Sun, 04 Oct 2026 19:11:29 +0900, Luke Yasuda wrote:
> It fails on tests without proxmox-frr-templates.
> 
> 

Applied with a small tweak to get it picked up both as build and as regular
dependency, thanks!

[1/1] proxmox-frr: add missing build-deps proxmox-frr-templates
      commit: a1fb9b5594f3a43d01bac63c8927054af8b2355f

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-05 11:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-04 10:11 [PATCH proxmox-ve-rs] proxmox-frr: add missing build-deps proxmox-frr-templates Luke Yasuda
2026-10-05  8:56 ` Gabriel Goller
2026-10-05 11:05 ` applied: " Fabian Grünbichler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal