[PATCH manager] fix #5798: ui: qemu pci edit: fix warning for shared IOMMU groups

[PATCH manager] fix #5798: ui: qemu pci edit: fix warning for shared IOMMU groups

[Michal Fox]

When selecting a raw PCI device, a warning should be shown if the device
is not in a separate IOMMU group. To not count the other functions of
the selected device itself, the check only compares the bus and device
part of the PCI IDs, by taking their first five characters.

But since the PCI selector also shows the domain, for example
'0000:01:00.0', the first five characters are just the domain. So all
devices of the same domain were treated as functions of the selected
device and the warning was never shown.

Compare everything before the function instead, so the domain, bus and
device, like the IOMMU check in the PCI mapping editor does.

Fixes: f36240c5 ("gui: pci passthrough: consider domain in PCISelector")
Signed-off-by: Michal Fox <me@dualfroz.com>
---
Tested by calling pciDevChange with a store where two devices share an
IOMMU group: before, the warning was not shown for either of them, now
it is, while it is still not shown for a device whose IOMMU group only
contains its own functions.

 www/manager6/qemu/PCIEdit.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
index 4e8ed744..3df64372 100644
--- a/www/manager6/qemu/PCIEdit.js
+++ b/www/manager6/qemu/PCIEdit.js
@@ -83,10 +83,10 @@ Ext.define('PVE.qemu.PCIInputPanel', {
                     return;
                 }
                 // try to find out if there are more devices in that iommu group
-                let id = path.substring(0, 5); // 00:00
+                let id = path.substring(0, path.indexOf('.')); // 0000:00:00
                 let count = 0;
                 pcisel.getStore().each(({ data }) => {
-                    if (data.iommugroup === iommu && data.id.substring(0, 5) !== id) {
+                    if (data.iommugroup === iommu && !data.id.startsWith(id)) {
                         count++;
                         return false;
                     }
-- 
2.43.0