public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Michal Fox <me@dualfroz.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server] fix #6907: memory: allow multi-digit host nodes with hugepages
Date: Sat, 26 Sep 2026 08:41:15 +0000	[thread overview]
Message-ID: <20260926084115.7-1-me@dualfroz.com> (raw)

When hugepages are enabled, each custom NUMA node must be bound to a
single host node. This was checked with a regex that only accepts a
single digit, so any host node from 10 upwards was rejected with a
misleading "more than 1 hostnode value" error, making hugepages
unusable on hosts with more than ten NUMA nodes.

Accept any single node number instead. Ranges and lists are still
rejected as before.

Signed-off-by: Michal Fox <me@dualfroz.com>
---
 src/PVE/QemuServer/Memory.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer/Memory.pm b/src/PVE/QemuServer/Memory.pm
index 27738cd9..9b7c24fa 100644
--- a/src/PVE/QemuServer/Memory.pm
+++ b/src/PVE/QemuServer/Memory.pm
@@ -640,7 +640,7 @@ sub hugepages_topology {
         my $hostnodes = print_numa_hostnodes($hostnodelists);
 
         die "more than 1 hostnode value in numa node is not supported when hugepages are enabled"
-            if $hostnodes !~ m/^(\d)$/;
+            if $hostnodes !~ m/^\d+$/;
         my $hugepages_size = hugepages_size($conf, $numa_memory);
         $hugepages_topology->{$hugepages_size}->{$hostnodes} +=
             hugepages_nr($numa_memory, $hugepages_size);
-- 
2.43.0




             reply	other threads:[~2026-09-28  7:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26  8:41 Michal Fox [this message]
2026-09-28 15:26 ` [PATCH qemu-server] fix #6907: memory: allow multi-digit host nodes with hugepages Max R. Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260926084115.7-1-me@dualfroz.com \
    --to=me@dualfroz.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal