From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 34E491FF09B for ; Mon, 28 Sep 2026 09:17:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EC0B5219C5; Mon, 28 Sep 2026 09:15:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dualfroz.com; s=dkim; t=1790412078; h=from:subject:date:message-id:to:mime-version: content-transfer-encoding; bh=A0VJ4mhPZ3N5YAcE1xIc21/FjtHlbbIxXj81sK3dWnA=; b=r+KNuwKofaa2N5Qdvj+ng+tSbPGS//VQBWdqTWXbnnMxPeg27AdSYdvif5+sYdBy1YGMmd OhARdyH/T820+zfTRQrVAqhISEhPYrWSOZzBZH+1waCAUyDpVWolz+g1hFSEU6p5Z+ydgv FnVh/F0AGJsTd/wwYT3filYSMaVs3d1luD0uCqtBH42KAa6KkvfRRiCh3nqusfU69c9xCH cLPFctl47eBvviDpXl0rbZeXBZUokwnEkIssCfpEz8W6FVJ1hqqZQRKrYHEPCmxQzjMfg3 EiUDiJpayt6qNfO/UHvL16XmFl2IOUEWt0K8uhp6oJtsU/sPOEsGDGx+pasamA== From: Michal Fox To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] fix #6907: memory: allow multi-digit host nodes with hugepages Date: Sat, 26 Sep 2026 08:41:15 +0000 Message-ID: <20260926084115.7-1-me@dualfroz.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.302 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: me@dualfroz.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: NCROZVWQYZBDYCPBJULUUQAPNTVKI36Y X-Message-ID-Hash: NCROZVWQYZBDYCPBJULUUQAPNTVKI36Y X-Mailman-Approved-At: Mon, 28 Sep 2026 09:14:43 +0200 X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When hugepages are enabled, each custom NUMA node must be bound to a single host node. This was checked with a regex that only accepts a single digit, so any host node from 10 upwards was rejected with a misleading "more than 1 hostnode value" error, making hugepages unusable on hosts with more than ten NUMA nodes. Accept any single node number instead. Ranges and lists are still rejected as before. Signed-off-by: Michal Fox --- src/PVE/QemuServer/Memory.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/QemuServer/Memory.pm b/src/PVE/QemuServer/Memory.pm index 27738cd9..9b7c24fa 100644 --- a/src/PVE/QemuServer/Memory.pm +++ b/src/PVE/QemuServer/Memory.pm @@ -640,7 +640,7 @@ sub hugepages_topology { my $hostnodes = print_numa_hostnodes($hostnodelists); die "more than 1 hostnode value in numa node is not supported when hugepages are enabled" - if $hostnodes !~ m/^(\d)$/; + if $hostnodes !~ m/^\d+$/; my $hugepages_size = hugepages_size($conf, $numa_memory); $hugepages_topology->{$hugepages_size}->{$hostnodes} += hugepages_nr($numa_memory, $hugepages_size); -- 2.43.0