[PATCH manager v6 17/18] api: nextid: reject IDs forbidden by next-id enforcement

["Michael Köppl" <m.koeppl@proxmox.com>]

With 'enforce' set in the next-id datacenter option, new guests may
only use IDs within the configured range and, with 'unique', IDs that
were not used before. Creating a guest with any other ID fails anyway,
but the GUI validates its guest ID field through this endpoint, so
reject such IDs here as well to report the problem before a task is
started.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 PVE/API2/Cluster.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
index e5017f6c4..995917f0a 100644
--- a/PVE/API2/Cluster.pm
+++ b/PVE/API2/Cluster.pm
@@ -1036,8 +1036,13 @@ __PACKAGE__->register_method({
         my $idlist = $vmlist->{ids} || {};
 
         if (my $vmid = $param->{vmid}) {
-            return $vmid if !defined($idlist->{$vmid});
-            raise_param_exc({ vmid => "VM $vmid already exists" });
+            raise_param_exc({ vmid => "VM $vmid already exists" })
+                if defined($idlist->{$vmid});
+
+            eval { PVE::GuestID::check_enforced_id($vmid) };
+            raise_param_exc({ vmid => $@ }) if $@;
+
+            return $vmid;
         }
 
         my $dc_conf = PVE::Cluster::cfs_read_file('datacenter.cfg');
-- 
2.47.3