[PATCH container v6 13/18] api, migrate: exempt existing CTs from next-id enforcement

["Michael Köppl" <m.koeppl@proxmox.com>]

With 'enforce' set in the next-id datacenter option,
register_used_id() rejects IDs outside the configured range and, with
'unique', IDs that were used before. That is only meant for IDs claimed
by new guests.

Destroying a CT and removing the source CT after a remote migration with
--delete both record the ID of a CT that already exists. That ID was
recorded when the CT was created and it may lie outside the configured
range if the range was changed later. Thus, exempt these cases from
enforcement.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 src/PVE/API2/LXC.pm    | 2 +-
 src/PVE/LXC/Migrate.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index fb4262c9..179eb3c4 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -884,7 +884,7 @@ __PACKAGE__->register_method({
         $early_checks->($conf);
 
         # record before destroying anything, so a failure here leaves the CT intact
-        eval { PVE::GuestID::register_used_id($vmid) };
+        eval { PVE::GuestID::register_used_id($vmid, { existing => 1 }) };
         die "unable to destroy CT $vmid - $@" if $@;
 
         my $running_error_msg = "unable to destroy CT $vmid - container is running\n";
diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index a215dede..5db867aa 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -542,7 +542,7 @@ sub final_cleanup {
             PVE::Tunnel::write_tunnel($self->{tunnel}, 60, 'start');
         }
         if ($self->{opts}->{delete}) {
-            eval { PVE::GuestID::register_used_id($vmid) };
+            eval { PVE::GuestID::register_used_id($vmid, { existing => 1 }) };
             warn $@ if $@;
 
             PVE::LXC::destroy_lxc_container(
-- 
2.47.3