public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu 1/2] build: check that copied sources are not dirty
Date: Tue, 22 Sep 2026 15:05:41 +0200	[thread overview]
Message-ID: <20260922130652.374790-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260922130652.374790-1-f.ebner@proxmox.com>

While commit fe22d79a16 ("build: clean copied QEMU sources") added a
'git clean' invocation, that does not catch a dirty state with removed
files. Check with 'git status' to catch that too.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Makefile b/Makefile
index 2ead600ced..a57bd3c08c 100644
--- a/Makefile
+++ b/Makefile
@@ -45,7 +45,9 @@ $(BUILDDIR): submodule
 	test ! -f $(SRCDIR)/build/config.status
 	rm -rf $@.tmp $@
 	cp -a $(SRCDIR) $@.tmp
+	# check that the git directory is not dirty
 	git -C $@.tmp clean -xdfi
+	test -z "$$(git -C $@.tmp status --porcelain=1)"
 	cp -a debian $@.tmp/debian
 	rm -rf $@.tmp/roms/edk2 # packaged separately
 	rm -rf $@.tmp/pc-bios/dtb
-- 
2.47.3





  reply	other threads:[~2026-09-22 13:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 13:05 [PATCH-SERIES qemu 0/2] build: more integrity checks of copied sources Fiona Ebner
2026-09-22 13:05 ` Fiona Ebner [this message]
2026-09-22 13:05 ` [PATCH qemu 2/2] build: track and check subproject state Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922130652.374790-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal