From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id DBDB51FF0AA for ; Tue, 22 Sep 2026 15:07:04 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 64DD721595; Tue, 22 Sep 2026 15:07:00 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu 1/2] build: check that copied sources are not dirty Date: Tue, 22 Sep 2026 15:05:41 +0200 Message-ID: <20260922130652.374790-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260922130652.374790-1-f.ebner@proxmox.com> References: <20260922130652.374790-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790082416039 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.544 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VLIW5R3X343I67W7AEWDVF7X2BLWWR2L X-Message-ID-Hash: VLIW5R3X343I67W7AEWDVF7X2BLWWR2L X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: While commit fe22d79a16 ("build: clean copied QEMU sources") added a 'git clean' invocation, that does not catch a dirty state with removed files. Check with 'git status' to catch that too. Signed-off-by: Fiona Ebner --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index 2ead600ced..a57bd3c08c 100644 --- a/Makefile +++ b/Makefile @@ -45,7 +45,9 @@ $(BUILDDIR): submodule test ! -f $(SRCDIR)/build/config.status rm -rf $@.tmp $@ cp -a $(SRCDIR) $@.tmp + # check that the git directory is not dirty git -C $@.tmp clean -xdfi + test -z "$$(git -C $@.tmp status --porcelain=1)" cp -a debian $@.tmp/debian rm -rf $@.tmp/roms/edk2 # packaged separately rm -rf $@.tmp/pc-bios/dtb -- 2.47.3