From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: applied: [PATCH storage] common: qemu-img: fix size units in function documentation
Date: Fri, 18 Sep 2026 10:50:24 +0200 [thread overview]
Message-ID: <20260918085033.30639-1-f.ebner@proxmox.com> (raw)
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/Storage/Common.pm | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.pm
index 53ff033..733d7fa 100644
--- a/src/PVE/Storage/Common.pm
+++ b/src/PVE/Storage/Common.pm
@@ -154,7 +154,8 @@ my sub run_qemu_img_json {
qemu_img_create($fmt, $size, $path, $options)
-Create a new qemu image with a specific format C<$format> and size C<$size> for a target C<$path>.
+Create a new qemu image with a specific format C<$format> and size C<$size> KiB for a target
+C<$path>.
C<$options> currently allows setting the C<preallocation> value.
@@ -240,7 +241,7 @@ sub qemu_img_info {
qemu_img_measure($size, $fmt, $timeout, $options)
Returns a json with the maximum size including all metadata overhead for an image with format
-C<$fmt> and original size C<$size>Kb.
+C<$fmt> and original size C<$size> KiB.
C<$options> allows specifying qemu-img options that might affect the sizing calculation, such as
cluster size.
@@ -265,9 +266,9 @@ sub qemu_img_measure {
qemu_img_resize($path, $format, $size, $preallocation, $timeout)
-Resize a qemu image C<$path> with format C<$format> to a target Kb size C<$size>. C<$preallocation>
-allows to specify the preallocation option for the resize operation. If no C<$timeout> is provided,
-it defaults to 10 seconds, or 1 hour when running in a worker context.
+Resize a qemu image C<$path> with format C<$format> to a target size C<$size> in bytes.
+C<$preallocation> allows to specify the preallocation option for the resize operation. If no
+C<$timeout> is provided, it defaults to 10 seconds, or 1 hour when running in a worker context.
=cut
--
2.47.3
reply other threads:[~2026-09-18 8:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918085033.30639-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox