From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 966211FF0C1 for ; Fri, 18 Sep 2026 10:50:45 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6910C21501; Fri, 18 Sep 2026 10:50:42 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: applied: [PATCH storage] common: qemu-img: fix size units in function documentation Date: Fri, 18 Sep 2026 10:50:24 +0200 Message-ID: <20260918085033.30639-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789721437019 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.626 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GEZNHCBRBZ6PW6FHVWGFC6DC4QEI6IJP X-Message-ID-Hash: GEZNHCBRBZ6PW6FHVWGFC6DC4QEI6IJP X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Fiona Ebner --- src/PVE/Storage/Common.pm | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.pm index 53ff033..733d7fa 100644 --- a/src/PVE/Storage/Common.pm +++ b/src/PVE/Storage/Common.pm @@ -154,7 +154,8 @@ my sub run_qemu_img_json { qemu_img_create($fmt, $size, $path, $options) -Create a new qemu image with a specific format C<$format> and size C<$size> for a target C<$path>. +Create a new qemu image with a specific format C<$format> and size C<$size> KiB for a target +C<$path>. C<$options> currently allows setting the C value. @@ -240,7 +241,7 @@ sub qemu_img_info { qemu_img_measure($size, $fmt, $timeout, $options) Returns a json with the maximum size including all metadata overhead for an image with format -C<$fmt> and original size C<$size>Kb. +C<$fmt> and original size C<$size> KiB. C<$options> allows specifying qemu-img options that might affect the sizing calculation, such as cluster size. @@ -265,9 +266,9 @@ sub qemu_img_measure { qemu_img_resize($path, $format, $size, $preallocation, $timeout) -Resize a qemu image C<$path> with format C<$format> to a target Kb size C<$size>. C<$preallocation> -allows to specify the preallocation option for the resize operation. If no C<$timeout> is provided, -it defaults to 10 seconds, or 1 hour when running in a worker context. +Resize a qemu image C<$path> with format C<$format> to a target size C<$size> in bytes. +C<$preallocation> allows to specify the preallocation option for the resize operation. If no +C<$timeout> is provided, it defaults to 10 seconds, or 1 hour when running in a worker context. =cut -- 2.47.3