From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH test-tools 4/4] buildsys: drop the proxmox-datacenter-manager submodule
Date: Thu, 10 Sep 2026 18:20:30 +0200 [thread overview]
Message-ID: <20260910162030.1776719-5-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20260910162030.1776719-1-m.koeppl@proxmox.com>
Nothing depends on pdm-api-types or pdm-client any more, so the whole
datacenter manager submodule can go. It was originally added for 2
library crates which are easily replicated here and this avoids the
entire PDM tree being pulled into the build.
Remove any dependencies only required by pdm-api-types and pdm-client as
well.
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
.gitmodules | 3 ---
Cargo.toml | 10 ----------
Makefile | 4 +---
README.md | 3 ---
debian/control | 11 -----------
proxmox-datacenter-manager | 1 -
6 files changed, 1 insertion(+), 31 deletions(-)
delete mode 100644 .gitmodules
delete mode 160000 proxmox-datacenter-manager
diff --git a/.gitmodules b/.gitmodules
deleted file mode 100644
index 93075c0..0000000
--- a/.gitmodules
+++ /dev/null
@@ -1,3 +0,0 @@
-[submodule "proxmox-datacenter-manager"]
- path = proxmox-datacenter-manager
- url = https://git.proxmox.com/git/proxmox-datacenter-manager.git
diff --git a/Cargo.toml b/Cargo.toml
index 7ac0bfb..2a9c359 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -29,24 +29,16 @@ percent-encoding = "2.1"
proxmox-client = "1.0"
proxmox-http = "1.0"
proxmox-login = "1.0"
-proxmox-serde = "1.0"
pve-api-types = "8.1"
serde = "1"
serde_plain = "1"
-# pdm-api-types
const_format = "0.2"
proxmox-acme-api = "1"
-proxmox-apt-api-types = "3.0.0"
proxmox-config-digest = "1"
proxmox-dns-api = "1"
-proxmox-installer-types = "0.2"
-proxmox-network-types = "1.1"
proxmox-section-config = "3"
-proxmox-subscription = { version = "1", features = [ "api-types"], default-features = false }
proxmox-time = "2"
-pbs-api-types = "1.0.3"
-proxmox-rrd-api-types = "1.0.2"
proxmox-tfa = { version = "6", features = [ "api-types" ], default-features = false }
proxmox-access-control = "1"
@@ -89,8 +81,6 @@ termcolor = "1.1"
tokio = "1.32"
toml = "0.8"
-pdm-api-types = { path = "./proxmox-datacenter-manager/lib/pdm-api-types/" }
-pdm-client = { path = "./proxmox-datacenter-manager/lib/pdm-client/" }
proxmox-product-config = "1"
proxmox-test-common = { path = "./proxmox-test-common/"}
diff --git a/Makefile b/Makefile
index 024bfa2..699626d 100644
--- a/Makefile
+++ b/Makefile
@@ -53,7 +53,7 @@ cargo-build-scheduler:
build: $(BUILDDIR)
$(BUILDDIR):
rm -rf $@ $@.tmp; mkdir $@.tmp
- cp -a proxmox-test-common proxmox-datacenter-manager proxmox-test-runner proxmox-test-instance proxmox-test-scheduler debian Cargo.toml LICENSE Makefile README.md defines.mk $@.tmp/
+ cp -a proxmox-test-common proxmox-test-runner proxmox-test-instance proxmox-test-scheduler debian Cargo.toml LICENSE Makefile README.md defines.mk $@.tmp/
mv $@.tmp $@
.PHONY: deb
@@ -126,8 +126,6 @@ gendeps:
cargo-fairy d-control \
./Cargo.toml \
proxmox-test-common/Cargo.toml \
- proxmox-datacenter-manager/lib/pdm-api-types/Cargo.toml \
- proxmox-datacenter-manager/lib/pdm-client/Cargo.toml \
proxmox-test-instance/Cargo.toml \
proxmox-test-runner/Cargo.toml \
proxmox-test-scheduler/Cargo.toml
diff --git a/README.md b/README.md
index 9b2f7bc..84c4828 100644
--- a/README.md
+++ b/README.md
@@ -16,9 +16,6 @@ JSON file the runner injects into each test via `$CONFIG_PATH` (see
| `proxmox-test-runner` | Runs the test cases from a testcase file against the instances described by an inventory file. |
| `proxmox-test-scheduler` | HTTPS daemon that coordinates CI runs over SSH: sets up instances, installs the packages under test, runs the runner, and mails the report. |
-`proxmox-datacenter-manager` is a git submodule; only its `pdm-api-types` and
-`pdm-client` crates are used (for the PDM client).
-
## Pipeline
```
diff --git a/debian/control b/debian/control
index 33b9a2c..b9216e9 100644
--- a/debian/control
+++ b/debian/control
@@ -28,15 +28,12 @@ Build-Depends: apt-utils,
librust-openssh-0.11+default-dev,
librust-openssh-0.11+process-mux-dev,
librust-openssl-0.10+default-dev (>= 0.10.45-~~),
- librust-pbs-api-types-1+default-dev (>= 1.0.3-~~),
librust-pico-args-0.5+default-dev,
- librust-proxmox-access-control-1+acl-dev,
librust-proxmox-access-control-1+api-dev,
librust-proxmox-access-control-1+default-dev,
librust-proxmox-acme-api-1+default-dev,
librust-proxmox-acme-api-1+impl-dev,
librust-proxmox-api-macro-1+default-dev (>= 1.4-~~),
- librust-proxmox-apt-api-types-3+default-dev,
librust-proxmox-async-0.5+default-dev,
librust-proxmox-auth-api-1+api-dev (>= 1.0.5-~~),
librust-proxmox-auth-api-1+api-types-dev (>= 1.0.5-~~),
@@ -51,31 +48,23 @@ Build-Depends: apt-utils,
librust-proxmox-dns-api-1+default-dev,
librust-proxmox-http-1+client-sync-dev,
librust-proxmox-http-1+default-dev,
- librust-proxmox-installer-types-0.2+api-types-dev,
- librust-proxmox-installer-types-0.2+default-dev,
librust-proxmox-lang-1+default-dev (>= 1.1-~~),
librust-proxmox-ldap-1+default-dev,
librust-proxmox-ldap-1+sync-dev,
librust-proxmox-log-1+default-dev,
librust-proxmox-login-1+default-dev,
librust-proxmox-network-api-1+default-dev,
- librust-proxmox-network-types-1+api-types-dev (>= 1.1-~~),
- librust-proxmox-network-types-1+default-dev (>= 1.1-~~),
librust-proxmox-product-config-1+default-dev,
librust-proxmox-rest-server-1+default-dev,
librust-proxmox-router-3+cli-dev (>= 3.2.4-~~),
- librust-proxmox-rrd-api-types-1+default-dev (>= 1.0.2-~~),
librust-proxmox-schema-5+api-macro-dev,
librust-proxmox-schema-5+default-dev,
librust-proxmox-section-config-3+default-dev,
- librust-proxmox-serde-1+default-dev,
librust-proxmox-sortable-macro-1+default-dev,
- librust-proxmox-subscription-1+api-types-dev,
librust-proxmox-sys-1+crypt-dev,
librust-proxmox-sys-1+default-dev,
librust-proxmox-systemd-1+default-dev,
librust-proxmox-tfa-6+api-types-dev,
- librust-proxmox-tfa-6+types-dev,
librust-proxmox-time-2+default-dev,
librust-proxmox-uuid-1+default-dev,
librust-proxmox-uuid-1+serde-dev,
diff --git a/proxmox-datacenter-manager b/proxmox-datacenter-manager
deleted file mode 160000
index 30f827a..0000000
--- a/proxmox-datacenter-manager
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 30f827a3dd1877517d5ba20de56391fd7b39098a
--
2.47.3
prev parent reply other threads:[~2026-09-10 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 16:20 [PATCH test-tools 0/4] remove PDM submodule Michael Köppl
2026-09-10 16:20 ` [PATCH test-tools 1/4] scheduler: drop the unused pdm-api-types dependency Michael Köppl
2026-09-10 16:20 ` [PATCH test-tools 2/4] instance: register PDM remotes without pdm-client Michael Köppl
2026-09-10 16:20 ` [PATCH test-tools 3/4] instance: source certificate and task types directly Michael Köppl
2026-09-10 16:20 ` Michael Köppl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910162030.1776719-5-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox