public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH test-tools 0/4] remove PDM submodule
Date: Thu, 10 Sep 2026 18:20:26 +0200	[thread overview]
Message-ID: <20260910162030.1776719-1-m.koeppl@proxmox.com> (raw)

The submodule was initially added to avoid reimplementing add_remote and
some of the structs and enums used for interacting with both the PDM as
well as the PVE API. In both cases, the functionality is so limited that
it doesn't really warrant pulling PDM into the build over reimplementing
these few pieces of code.

These patches remove the dependency from proxmox-test-scheduler (where
it was unused anyway) and proxmox-test-instance and all the dependencies
that were only pulled in for proxmox-datacenter-manager. The
functionality for adding remotes is reimplemented here, but keeps only
the parts actually required for proxmox-test-instance's use case.

I ran multiple different plans with and without clusters, adding the
test instances as remotes for a PDM instance and did not notice any
problems. I also verified that `wait_for_task` still works as expected
since it was using `TaskStateType` from pdm_api_types.


proxmox-test-tools:

Michael Köppl (4):
  scheduler: drop the unused pdm-api-types dependency
  instance: register PDM remotes without pdm-client
  instance: source certificate and task types directly
  buildsys: drop the proxmox-datacenter-manager submodule

 .gitmodules                                 |  3 -
 Cargo.toml                                  | 10 ---
 Makefile                                    |  4 +-
 README.md                                   |  3 -
 debian/control                              | 11 ---
 proxmox-datacenter-manager                  |  1 -
 proxmox-test-instance/Cargo.toml            |  6 +-
 proxmox-test-instance/src/api/pdm_client.rs | 76 +++++++++++++++++----
 proxmox-test-instance/src/api/pve_client.rs | 26 ++++++-
 proxmox-test-scheduler/Cargo.toml           |  2 -
 10 files changed, 92 insertions(+), 50 deletions(-)
 delete mode 100644 .gitmodules
 delete mode 160000 proxmox-datacenter-manager


Summary over all repositories:
  10 files changed, 92 insertions(+), 50 deletions(-)

-- 
Generated by murpp 0.12.1




             reply	other threads:[~2026-09-10 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 16:20 Michael Köppl [this message]
2026-09-10 16:20 ` [PATCH test-tools 1/4] scheduler: drop the unused pdm-api-types dependency Michael Köppl
2026-09-10 16:20 ` [PATCH test-tools 2/4] instance: register PDM remotes without pdm-client Michael Köppl
2026-09-10 16:20 ` [PATCH test-tools 3/4] instance: source certificate and task types directly Michael Köppl
2026-09-10 16:20 ` [PATCH test-tools 4/4] buildsys: drop the proxmox-datacenter-manager submodule Michael Köppl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910162030.1776719-1-m.koeppl@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal