From: Daniel Herzig <d.herzig@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-network v3 0/3] make sure to use subnet config if available at point
Date: Mon, 7 Sep 2026 16:28:18 +0200 [thread overview]
Message-ID: <20260907142821.563945-1-d.herzig@proxmox.com> (raw)
At certain places (SimplePlugin, EvpnPlugin) subnets were read from the
running config instead of the one passed in, so callers that generate without
committing first, like the dry-run, never saw pending subnet changes in the result.
This series changes this behaviour by introducing a function that makes use of
an existing subnet configuration if available at point.
To avoid code duplication, the function is also used from the original 'get_subnets'
for by callers, that do not have the subnet configuration by hand, here passing in the
configuration retrieved by the the original call to PVE::Network::SDN::Subnets::config.
Changes since v1:
* use 'get_subnets_with_config' in original 'get_subnets' as well.
* use 'get_subnets_with_config' in EvpnPlugin and Dhcp in addition to SimplePlugin.
Changes since v2:
* make use of 'for' instead of 'foreach' in introduced sub.
* drop patch for Dhcp.pm (offtopic).
Daniel Herzig (3):
vnets: introduce get_subnets_with_config
fix #7837: simpleplugin: make use of get_subnets_with_config
evpnplugin: make use of get_subnets_with_config
src/PVE/Network/SDN/Vnets.pm | 9 +++++++--
src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 +-
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 2 +-
3 files changed, 9 insertions(+), 4 deletions(-)
--
2.47.3
next reply other threads:[~2026-09-07 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 14:28 Daniel Herzig [this message]
2026-09-07 14:28 ` [pve-network v3 1/3] vnets: introduce get_subnets_with_config Daniel Herzig
2026-09-07 14:28 ` [pve-network v3 2/3] fix #7837: simpleplugin: make use of get_subnets_with_config Daniel Herzig
2026-09-07 14:28 ` [pve-network v3 3/3] evpnplugin: " Daniel Herzig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907142821.563945-1-d.herzig@proxmox.com \
--to=d.herzig@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox