From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 6F5061FF0AA for ; Mon, 07 Sep 2026 16:28:40 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F168A21576; Mon, 07 Sep 2026 16:28:29 +0200 (CEST) From: Daniel Herzig To: pve-devel@lists.proxmox.com Subject: [pve-network v3 0/3] make sure to use subnet config if available at point Date: Mon, 7 Sep 2026 16:28:18 +0200 Message-ID: <20260907142821.563945-1-d.herzig@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.942 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: R6RB4TJ2IV34YYJKGMVXYPK2OYGA4GJC X-Message-ID-Hash: R6RB4TJ2IV34YYJKGMVXYPK2OYGA4GJC X-MailFrom: dherzig@emma.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: At certain places (SimplePlugin, EvpnPlugin) subnets were read from the running config instead of the one passed in, so callers that generate without committing first, like the dry-run, never saw pending subnet changes in the result. This series changes this behaviour by introducing a function that makes use of an existing subnet configuration if available at point. To avoid code duplication, the function is also used from the original 'get_subnets' for by callers, that do not have the subnet configuration by hand, here passing in the configuration retrieved by the the original call to PVE::Network::SDN::Subnets::config. Changes since v1: * use 'get_subnets_with_config' in original 'get_subnets' as well. * use 'get_subnets_with_config' in EvpnPlugin and Dhcp in addition to SimplePlugin. Changes since v2: * make use of 'for' instead of 'foreach' in introduced sub. * drop patch for Dhcp.pm (offtopic). Daniel Herzig (3): vnets: introduce get_subnets_with_config fix #7837: simpleplugin: make use of get_subnets_with_config evpnplugin: make use of get_subnets_with_config src/PVE/Network/SDN/Vnets.pm | 9 +++++++-- src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 +- src/PVE/Network/SDN/Zones/SimplePlugin.pm | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) -- 2.47.3