From: Elias Huhsovitz <e.huhsovitz@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: [PATCH manager v2] fix #6211: ui: vm: options: add description to protection option
Date: Mon, 10 Aug 2026 12:35:47 +0200 [thread overview]
Message-ID: <20260810103547.73198-1-e.huhsovitz@proxmox.com> (raw)
The `Protection` option might be ambiguous for new users. Add a short
description of the option in the same style as the options `Freeze CPU
at startup` and `Start at boot`.
Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
changes v1 -> v2:
* match style of existing options `Freeze CPU at startup` and `Start at boot`.
* Reword commit message.
v1: https://lore.proxmox.com/pve-devel/20260713114657.147881-1-e.huhsovitz@proxmox.com/
IMHO: The option should be renamed to something like `Prevent VM and disk removal`,
instead of `Protection`.
But this might confuse long term users as noted in [1]. Therefore i chose to simply
update the label.
[1] https://lore.proxmox.com/pve-devel/c5c7991a-919f-4ec4-a2e7-86f00d439149@proxmox.com/
www/manager6/lxc/Options.js | 5 ++++-
www/manager6/qemu/Options.js | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
index d475d4d8..c4521255 100644
--- a/www/manager6/lxc/Options.js
+++ b/www/manager6/lxc/Options.js
@@ -134,7 +134,10 @@ Ext.define('PVE.lxc.Options', {
uncheckedValue: 0,
defaultValue: 0,
deleteDefaultValue: true,
- fieldLabel: gettext('Enabled'),
+ labelWidth: Proxmox.Utils.compute_min_label_width(
+ gettext('Prevent VM and disk removal'),
+ ),
+ fieldLabel: gettext('Prevent VM and disk removal'),
},
}
: undefined,
diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
index 8a4721a0..0ea4cb2d 100644
--- a/www/manager6/qemu/Options.js
+++ b/www/manager6/qemu/Options.js
@@ -325,7 +325,10 @@ Ext.define('PVE.qemu.Options', {
uncheckedValue: 0,
defaultValue: 0,
deleteDefaultValue: true,
- fieldLabel: gettext('Enabled'),
+ labelWidth: Proxmox.Utils.compute_min_label_width(
+ gettext('Prevent VM and disk removal'),
+ ),
+ fieldLabel: gettext('Prevent VM and disk removal'),
},
}
: undefined,
--
2.47.3
reply other threads:[~2026-08-10 10:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810103547.73198-1-e.huhsovitz@proxmox.com \
--to=e.huhsovitz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox