[PATCH qemu-server 1/8] block job: monitor: avoid duplicate completion

[Fiona Ebner <f.ebner@proxmox.com>]

If the QMP command for completion (i.e. complete or cancel) is
successful, the job transitions to the next state in QEMU. So a
duplicate completion command won't usually do anything. A job might
take some time to actually complete, so at the moment, completion
handling may happen multiple times. This produces confusing duplicate
log lines and can actually lead to unnecessary failure with bad
timing, if the job transitions to state 'concluded' after between
querying the status and issuing the next complete:

> VM 100 qmp command 'job-complete' failed - \
> Job 'mirror-scsi0' in state 'concluded' cannot \
> accept command verb 'complete'

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer/BlockJob.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm
index 921f046c..254d7906 100644
--- a/src/PVE/QemuServer/BlockJob.pm
+++ b/src/PVE/QemuServer/BlockJob.pm
@@ -196,6 +196,8 @@ sub monitor {
                 } else {
 
                     for my $job_id (sort keys %$jobs) {
+                        next if $jobs->{$job_id}->{complete};
+
                         # try to switch the disk if source and destination are on the same guest
                         print "$job_id: Completing block job...\n";
 
-- 
2.47.3