public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH-SERIES qemu-server 0/8] block job: monitor: improve completion handling and style
Date: Thu, 30 Jul 2026 15:15:49 +0200	[thread overview]
Message-ID: <20260730131613.157722-1-f.ebner@proxmox.com> (raw)

Avoid issuing duplicate completes and printing duplicate log messages
when a job does not complete right away. This also avoids an
unnecessary failure that could arise with bad timing.

Avoid sleeping for a full second each time while waiting for
completion to benefit migration. This partially solves #7854.

Further, factor out the status printing from monitor(), clean up its
signature and properly document it.

qemu-server:

Fiona Ebner (8):
  block job: monitor: avoid duplicate completion
  block job: monitor: only print message that jobs are ready once
  partially fix #7854: block job: monitor: handle completion faster to
    benefit migration
  block job: monitor: factor out job status printing
  block job: monitor: make operation argument non-optional
  block job: monitor: rename 'op' argument to 'operation'
  block job: monitor: pass options as a hash
  block job: monitor: properly document function

 src/PVE/QemuMigrate.pm                    |   5 +-
 src/PVE/QemuServer.pm                     |  14 +-
 src/PVE/QemuServer/BlockJob.pm            | 168 +++++++++++++++-------
 src/PVE/QemuServer/VolumeChain.pm         |   4 +-
 src/test/MigrationTest/QemuMigrateMock.pm |   2 +-
 5 files changed, 131 insertions(+), 62 deletions(-)


Summary over all repositories:
  5 files changed, 131 insertions(+), 62 deletions(-)

-- 
Generated by git-murpp 0.5.0




             reply	other threads:[~2026-07-30 13:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 13:15 Fiona Ebner [this message]
2026-07-30 13:15 ` [PATCH qemu-server 1/8] block job: monitor: avoid duplicate completion Fiona Ebner
2026-07-30 13:15 ` [PATCH qemu-server 2/8] block job: monitor: only print message that jobs are ready once Fiona Ebner
2026-07-30 13:15 ` [PATCH qemu-server 3/8] partially fix #7854: block job: monitor: handle completion faster to benefit migration Fiona Ebner
2026-07-30 13:15 ` [PATCH qemu-server 4/8] block job: monitor: factor out job status printing Fiona Ebner
2026-07-30 13:15 ` [PATCH qemu-server 5/8] block job: monitor: make operation argument non-optional Fiona Ebner
2026-07-30 13:15 ` [PATCH qemu-server 6/8] block job: monitor: rename 'op' argument to 'operation' Fiona Ebner
2026-07-30 13:15 ` [PATCH qemu-server 7/8] block job: monitor: pass options as a hash Fiona Ebner
2026-07-30 13:15 ` [PATCH qemu-server 8/8] block job: monitor: properly document function Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730131613.157722-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal