From: Kaiyang Wu <wukaiyang2003@gmail.com>
To: pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: [PATCH qemu-server v3] query-machine-capabilities: limit AuthenticAMD and GenuineIntel checks to x86-64
Date: Thu, 30 Jul 2026 09:47:05 +0800 [thread overview]
Message-ID: <20260730014713.64822-2-wukaiyang@loongfans.cn> (raw)
Intel TDX and AMD SEV are both x86-64-only extensions [0] [1]. The current
method of checking results in compilation errors on "unknown" vendors,
where the current placeholder string length ("Unknown") mismatches the
lengths of both "AuthenticAMD" and "GenuineIntel":
error: ‘strncmp’ of strings of length 7 and 12 and bound of 12
evaluates to nonzero [-Werror=string-compare]
Limit the machine capability checks for Intel TDX and AMD SEV to x86-64 to
fix build.
[0]: https://docs.kernel.org/arch/x86/tdx.html
[1]: https://docs.kernel.org/virt/kvm/x86/amd-memory-encryption.html
Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
---
v1: https://lore.proxmox.com/pve-devel/20260603055031.106241-1-wukaiyang@loongfans.cn/
v2: https://lore.proxmox.com/pve-devel/20260729111024.58285-2-wukaiyang@loongfans.cn/
Changes v1 -> v2:
- Use conditional compilation to limit Intel TDX and AMD SEV checks to x86-64
- Eliminate the vendor string length check
Changes v2 -> v3:
- Remove the extra 'else' block to fix compilation on aarch64
.../query-machine-capabilities.c | 31 +++++++++----------
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/query-machine-capabilities/query-machine-capabilities.c b/src/query-machine-capabilities/query-machine-capabilities.c
index abb47acd..b47ed698 100644
--- a/src/query-machine-capabilities/query-machine-capabilities.c
+++ b/src/query-machine-capabilities/query-machine-capabilities.c
@@ -204,6 +204,7 @@ int main() {
eprintf("Error writing to file '" OUTPUT_PATH "': %s\n", strerror(errno));
}
+#ifdef __x86_64__
if (strncmp(vendor, "AuthenticAMD", 12) == 0) {
cpu_caps_amd_sev_t caps_sev;
query_cpu_capabilities_sev(&caps_sev);
@@ -233,22 +234,20 @@ int main() {
);
}
}
-#ifdef __aarch64__
- else {
- cpu_caps_arm_t caps_arm;
- query_cpu_capabilities_arm(&caps_arm);
-
- ret = fprintf(file,
- " \"arm-caps\": {"
- " \"vendor\": \"%s\","
- " \"aes\": %s,"
- " \"sha2\": %s"
- " }",
- vendor,
- caps_arm.aes ? "true" : "false",
- caps_arm.sha2 ? "true" : "false"
- );
- }
+#elif defined(__aarch64__)
+ cpu_caps_arm_t caps_arm;
+ query_cpu_capabilities_arm(&caps_arm);
+
+ ret = fprintf(file,
+ " \"arm-caps\": {"
+ " \"vendor\": \"%s\","
+ " \"aes\": %s,"
+ " \"sha2\": %s"
+ " }",
+ vendor,
+ caps_arm.aes ? "true" : "false",
+ caps_arm.sha2 ? "true" : "false"
+ );
#endif
if (ret < 0) {
--
2.55.0
reply other threads:[~2026-07-30 1:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730014713.64822-2-wukaiyang@loongfans.cn \
--to=wukaiyang2003@gmail.com \
--cc=pve-devel@lists.proxmox.com \
--cc=wukaiyang@loongfans.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox