[PATCH manager 1/1] ui: crs: add tech preview warning for rebalance on start

[PATCH manager 1/1] ui: crs: add tech preview warning for rebalance on start

[Michael Köppl]

For static and dynamic scheduling modes, rebalance on start is in
technology preview [0]. Display a warning message if either "Static
Load" or "Dynamic Load" is selected and the "Rebalance on Start"
checkbox is checked.

Also renames the canUseAutoRebalancing formula since the predicate now
has a second consumer that is separate from the auto-rebalancing
option, so the old name described one of its callers rather than the
condition it tests. Naming the condition itself avoids duplicating the
formula check for the hint's visibility binding.

This avoids confusion about the status [1] of the feature given what is
stated in the documentation.

[0] https://pve.proxmox.com/pve-docs/chapter-ha-manager.html#_ha_resource_rebalance_on_start_opt_in
[1] https://forum.proxmox.com/threads/185390/

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 www/manager6/form/CRSOptions.js | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/www/manager6/form/CRSOptions.js b/www/manager6/form/CRSOptions.js
index 84f6d5062..75611ce23 100644
--- a/www/manager6/form/CRSOptions.js
+++ b/www/manager6/form/CRSOptions.js
@@ -21,12 +21,15 @@ Ext.define('PVE.form.CRSOptions', {
         data: {
             crsMode: '__default__',
             autoRebalancing: 0,
+            rebalanceOnStart: 0,
         },
         formulas: {
-            canUseAutoRebalancing: (get) =>
+            loadBasedScheduling: (get) =>
                 get('crsMode') === 'static' || get('crsMode') === 'dynamic',
             autoRebalancingDisabled: (get) =>
-                !get('autoRebalancing') || !get('canUseAutoRebalancing'),
+                !get('autoRebalancing') || !get('loadBasedScheduling'),
+            rebalanceOnStartHintHidden: (get) =>
+                !get('rebalanceOnStart') || !get('loadBasedScheduling'),
         },
     },
 
@@ -64,6 +67,19 @@ Ext.define('PVE.form.CRSOptions', {
                         'Use CRS to select the least loaded node when starting an HA resource',
                     ),
                     value: 0,
+                    bind: {
+                        value: '{rebalanceOnStart}',
+                    },
+                },
+                {
+                    xtype: 'displayfield',
+                    userCls: 'pmx-hint',
+                    value: gettext(
+                        'Rebalance on Start is currently a technology preview for the Static Load and Dynamic Load scheduling modes. It is not recommended for clusters with thousands of HA resources.',
+                    ),
+                    bind: {
+                        hidden: '{rebalanceOnStartHintHidden}',
+                    },
                 },
                 {
                     xtype: 'proxmoxcheckbox',
@@ -72,7 +88,7 @@ Ext.define('PVE.form.CRSOptions', {
                     boxLabel: gettext('Automatically rebalance HA resources'),
                     bind: {
                         value: '{autoRebalancing}',
-                        disabled: '{!canUseAutoRebalancing}',
+                        disabled: '{!loadBasedScheduling}',
                     },
                 },
                 {
-- 
2.47.3