public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH perlmod v2 0/5] perlmod: add #[hash] parameter attribute
Date: Fri, 24 Jul 2026 16:49:02 +0200	[thread overview]
Message-ID: <20260724144914.658730-1-m.carrara@proxmox.com> (raw)

perlmod: add #[hash] parameter attribute - v2
=============================================

This series implements a `#[hash]` parameter similar to the existing
`#[list]` one, allowing us to create APIs like
`foo("arg", key => "value")` directly from Rust.

In other words, this essentially mirrors how a sub with `%params` as its
last parameter would work.

For example, this is one of the functions called by the tests that are
added in this series:

    #[export]
    fn trailing_hash(first: u32, #[hash] rest: HashMap<u32, u32>) -> String {
        format!("first={first}, rest is {rest:?}")
    }

This can then be called e.g. like this:

    let $res = TestLib::Hello::trailing_hash(42, 1337 => 123);

Changes Since v1
----------------

- Drop patches that were already applied (thanks!)

- Call it "parameter attribute", not "parameter"

- Take Wolfgang's feedback (thanks!) on patch #3 of v1 into account and
  refactor the majority of `perlmod-macro/src/function.rs` before
  actually implementing the #[hash] parameter attribute.

  This means that all patches but the last just massage `function.rs`
  into a shape that makes it convenient to add and debug new parameter
  attributes. The overall logic was improved as well, making it more
  clear / explicit what's happening in a given block of code.

The tests and docstrings added in the last patch are otherwise kept
identical, including the implementation of `ParamsIter<I>`.

Previous Versions
-----------------

v1: https://lore.proxmox.com/pve-devel/20260720152541.524463-1-m.carrara@proxmox.com/

Summary of Changes
------------------


perlmod:

Max R. Carrara (5):
  macro: function: make argument code generation helpers standalone fns
  macro: function: make argument attribute handling more extendable
  macro: function: explicitly pass identifier for generated arg iter
  macro: function: move signature inputs handling into helper struct
  perlmod, macro: add #[hash] parameter attribute

 perlmod-macro/src/function.rs | 648 ++++++++++++++++++++++------------
 perlmod/src/de.rs             |  44 +++
 perlmod/src/lib.rs            |   5 +
 testlib-tests/01-hello.t      |  46 ++-
 testlib/src/lib.rs            |  24 +-
 5 files changed, 538 insertions(+), 229 deletions(-)


Summary over all repositories:
  5 files changed, 538 insertions(+), 229 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-07-24 14:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24 14:49 Max R. Carrara [this message]
2026-07-24 14:49 ` [PATCH perlmod v2 1/5] macro: function: make argument code generation helpers standalone fns Max R. Carrara
2026-07-24 14:49 ` [PATCH perlmod v2 2/5] macro: function: make argument attribute handling more extendable Max R. Carrara
2026-07-24 14:49 ` [PATCH perlmod v2 3/5] macro: function: explicitly pass identifier for generated arg iter Max R. Carrara
2026-07-24 14:49 ` [PATCH perlmod v2 4/5] macro: function: move signature inputs handling into helper struct Max R. Carrara
2026-07-24 14:49 ` [PATCH perlmod v2 5/5] perlmod, macro: add #[hash] parameter attribute Max R. Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724144914.658730-1-m.carrara@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal