From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 616C11FF0E6 for ; Fri, 24 Jul 2026 16:49:20 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1B9C121508; Fri, 24 Jul 2026 16:49:20 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH perlmod v2 0/5] perlmod: add #[hash] parameter attribute Date: Fri, 24 Jul 2026 16:49:02 +0200 Message-ID: <20260724144914.658730-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784904524081 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZKNOLLLHNHUEQHSQZ7YP47VOZBZHN6OV X-Message-ID-Hash: ZKNOLLLHNHUEQHSQZ7YP47VOZBZHN6OV X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: perlmod: add #[hash] parameter attribute - v2 ============================================= This series implements a `#[hash]` parameter similar to the existing `#[list]` one, allowing us to create APIs like `foo("arg", key => "value")` directly from Rust. In other words, this essentially mirrors how a sub with `%params` as its last parameter would work. For example, this is one of the functions called by the tests that are added in this series: #[export] fn trailing_hash(first: u32, #[hash] rest: HashMap) -> String { format!("first={first}, rest is {rest:?}") } This can then be called e.g. like this: let $res = TestLib::Hello::trailing_hash(42, 1337 => 123); Changes Since v1 ---------------- - Drop patches that were already applied (thanks!) - Call it "parameter attribute", not "parameter" - Take Wolfgang's feedback (thanks!) on patch #3 of v1 into account and refactor the majority of `perlmod-macro/src/function.rs` before actually implementing the #[hash] parameter attribute. This means that all patches but the last just massage `function.rs` into a shape that makes it convenient to add and debug new parameter attributes. The overall logic was improved as well, making it more clear / explicit what's happening in a given block of code. The tests and docstrings added in the last patch are otherwise kept identical, including the implementation of `ParamsIter`. Previous Versions ----------------- v1: https://lore.proxmox.com/pve-devel/20260720152541.524463-1-m.carrara@proxmox.com/ Summary of Changes ------------------ perlmod: Max R. Carrara (5): macro: function: make argument code generation helpers standalone fns macro: function: make argument attribute handling more extendable macro: function: explicitly pass identifier for generated arg iter macro: function: move signature inputs handling into helper struct perlmod, macro: add #[hash] parameter attribute perlmod-macro/src/function.rs | 648 ++++++++++++++++++++++------------ perlmod/src/de.rs | 44 +++ perlmod/src/lib.rs | 5 + testlib-tests/01-hello.t | 46 ++- testlib/src/lib.rs | 24 +- 5 files changed, 538 insertions(+), 229 deletions(-) Summary over all repositories: 5 files changed, 538 insertions(+), 229 deletions(-) -- Generated by murpp 0.11.0