[PATCH qemu-server 4/9] blockdev: attach: support explicitly attaching as writeable

[Fiona Ebner <f.ebner@proxmox.com>]

If the read-only option is explicitly set to 0, override the drive
configuration and attach the drive as writeable. This is useful for
making exports and mirror targets below throttle writeable even if the
drive itself is configured as read-only.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer/Blockdev.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/PVE/QemuServer/Blockdev.pm b/src/PVE/QemuServer/Blockdev.pm
index 101c747c..879e1aab 100644
--- a/src/PVE/QemuServer/Blockdev.pm
+++ b/src/PVE/QemuServer/Blockdev.pm
@@ -202,7 +202,9 @@ sub get_node_name_below_throttle {
 my sub read_only_json_option {
     my ($drive, $options) = @_;
 
-    return json_bool($drive->{ro} || drive_is_cdrom($drive) || $options->{'read-only'});
+    return json_bool($options->{'read-only'}) if defined($options->{'read-only'});
+
+    return json_bool($drive->{ro} || drive_is_cdrom($drive));
 }
 
 # Common blockdev options that need to be set across the whole throttle->fmt->file chain.
@@ -571,8 +573,8 @@ Parameters:
 
 =item C<< $options->{'no-throttle'} >>: Do not insert a throttle node as the top node.
 
-=item C<< $options->{'read-only'} >>: Attach the image as read-only irrespective of the
-configuration in C<$drive>.
+=item C<< $options->{'read-only'} >>: Attach the image as read-only or as writeable irrespective of
+the configuration in C<$drive>.
 
 =item C<< $options->{size} >>: Attach the image with this virtual size. Must be smaller than the
 actual size of the image. The image format must be C<raw>.
-- 
2.47.3