public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 5/7] fix #7230: api: vm_shutdown: make HA resources acknowledge config timeout
Date: Wed, 22 Jul 2026 16:01:47 +0200	[thread overview]
Message-ID: <20260722140149.296952-6-d.kral@proxmox.com> (raw)
In-Reply-To: <20260722140149.296952-1-d.kral@proxmox.com>

Allow users to configure the shutdown timeout of HA resources by
acknowledging the shutdown timeout value from the VM config.

This does only partially fix #7230 as HA resources are still
force-stopped as the LRM will always set the flag.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 src/PVE/API2/Qemu.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 304805dc..2613aea0 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -3899,6 +3899,12 @@ __PACKAGE__->register_method({
         raise_param_exc({ keepActive => "Only root may use this option." })
             if $keepActive && $authuser ne 'root@pam';
 
+        my $timeout = extract_param($param, 'timeout');
+        if (!defined($timeout)) {
+            my $conf = PVE::QemuConfig->load_config($vmid);
+            $timeout = PVE::QemuServer::Helpers::config_aware_shutdown_timeout($conf);
+        }
+
         my $storecfg = PVE::Storage::config();
 
         my $shutdown = 1;
@@ -3916,7 +3922,6 @@ __PACKAGE__->register_method({
 
         if (PVE::HA::Config::vm_is_ha_managed($vmid) && $rpcenv->{type} ne 'ha') {
 
-            my $timeout = $param->{timeout} // 60;
             my $hacmd = sub {
                 my $upid = shift;
 
@@ -3941,7 +3946,7 @@ __PACKAGE__->register_method({
                     $vmid,
                     $skiplock,
                     0,
-                    $param->{timeout},
+                    $timeout,
                     $shutdown,
                     $param->{forceStop},
                     $keepActive,
-- 
2.47.3





  parent reply	other threads:[~2026-07-22 14:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 14:01 [PATCH-SERIES ha-manager/qemu-server 0/7] fix #7230: acknowledge configured shutdown timeout for HA resources Daniel Kral
2026-07-22 14:01 ` [PATCH qemu-server 1/7] rename config_aware_timeout to config_aware_start_timeout Daniel Kral
2026-07-22 14:01 ` [PATCH qemu-server 2/7] vm_stop: introduce config_aware_shutdown_timeout helper Daniel Kral
2026-07-22 14:01 ` [PATCH qemu-server 3/7] api: qemu: improve wording in timeout parameter descriptions Daniel Kral
2026-07-22 14:01 ` [PATCH qemu-server 4/7] api: qemu: add verbose description for shutdown and reboot timeouts Daniel Kral
2026-07-22 14:01 ` Daniel Kral [this message]
2026-07-22 14:01 ` [PATCH qemu-server 6/7] api: vm_reboot: initialize the config-aware timeout in API handler Daniel Kral
2026-07-22 14:01 ` [PATCH ha-manager 7/7] fix #7230: resources: let shutdown api handle timeout fallback value Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722140149.296952-6-d.kral@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal