[PATCH-SERIES ha-manager/qemu-server 0/7] fix #7230: acknowledge configured shutdown timeout for HA resources

[Daniel Kral <d.kral@proxmox.com>]

If a shutdown request is issued for HA resources, the vm_shutdown API
handler and the VM-related HA code will always fallback to 60 seconds.

Partially fix #7230 by acknowledging the shutdown timeout value in the
VM config and only fallback to 60 seconds otherwise. This allows users
to at least set a better timeout value through the VM config.



However, this patch series doesn't implement being able to set the value
for --force-stop yet, because similar to #7053 [0], the line-based
crm_commands are not easily extendable without some churn to accomodate
different pve-ha-{crm,lrm} versions across the cluster to add the
--force-stop value to it...

We should make the crm_commands format more extendible as we might run
into more cases where we want to pass relevant parameters through the HA
stack without racy/error-prone code that circles around the problem [1].

Though maybe --force-stop 0 could be the new default behavior in the HA
stack as long as we spawn new 'request_stop' resource commands and
probably introduce some 'max-stop' config for each HA resource so this
doesn't end up in an infinite stop loop if for some reason the HA
resource really cannot be stopped.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=7053
[1] https://lore.proxmox.com/pve-devel/DGYA16ZRKXXY.3CJFSGFKT7K79@proxmox.com/


qemu-server:

Daniel Kral (6):
  rename config_aware_timeout to config_aware_start_timeout
  vm_stop: introduce config_aware_shutdown_timeout helper
  api: qemu: improve wording in timeout parameter descriptions
  api: qemu: add verbose description for shutdown and reboot timeouts
  fix #7230: api: vm_shutdown: make HA resources acknowledge config
    timeout
  api: vm_reboot: initialize the config-aware timeout in API handler

 src/PVE/API2/Qemu.pm          | 33 ++++++++++++++++++++++++++-------
 src/PVE/QemuMigrate.pm        |  4 ++--
 src/PVE/QemuServer.pm         |  9 +++------
 src/PVE/QemuServer/Helpers.pm | 17 +++++++++++++++--
 4 files changed, 46 insertions(+), 17 deletions(-)


ha-manager:

Daniel Kral (1):
  fix #7230: resources: let shutdown api handle timeout fallback value

 src/PVE/HA/Resources/PVECT.pm | 10 +++++-----
 src/PVE/HA/Resources/PVEVM.pm | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)


Summary over all repositories:
  6 files changed, 56 insertions(+), 27 deletions(-)

-- 
Generated by murpp 0.12.0