public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: David Riley <d.riley@proxmox.com>
Subject: [PATCH manager v3 10/16] ui: ha: resource affinity: add hint for affinity type config value
Date: Wed, 22 Jul 2026 10:48:18 +0200	[thread overview]
Message-ID: <20260722084824.108350-11-d.kral@proxmox.com> (raw)
In-Reply-To: <20260722084824.108350-1-d.kral@proxmox.com>

The resource affinity rule grid does show the config values 'positive'
and 'negative' for each resource affinity rule, while the create/edit
dialog shows the descriptive texts 'Keep Together' and 'Keep Separate'.

Make a link between those values by adding the config values to the more
user-friendly texts.

Suggested-by: David Riley <d.riley@proxmox.com>
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
changes since v2:
- new!

 www/manager6/ha/rules/ResourceAffinityRuleEdit.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/ha/rules/ResourceAffinityRuleEdit.js b/www/manager6/ha/rules/ResourceAffinityRuleEdit.js
index 6e375c4c..7dc9e10e 100644
--- a/www/manager6/ha/rules/ResourceAffinityRuleEdit.js
+++ b/www/manager6/ha/rules/ResourceAffinityRuleEdit.js
@@ -13,8 +13,8 @@ Ext.define('PVE.ha.rules.ResourceAffinityInputPanel', {
                 fieldLabel: gettext('Affinity'),
                 allowBlank: false,
                 comboItems: [
-                    ['positive', gettext('Keep Together')],
-                    ['negative', gettext('Keep Separate')],
+                    ['positive', `${gettext('Keep Together')} (positive)`],
+                    ['negative', `${gettext('Keep Separate')} (negative)`],
                 ],
             },
         ];
-- 
2.47.3





  parent reply	other threads:[~2026-07-22  8:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  8:48 [PATCH-SERIES docs/ha-manager/manager v3 00/16] Negative Node Affinity Rules Daniel Kral
2026-07-22  8:48 ` [PATCH ha-manager v3 01/16] rules: node affinity: add affinity property to node affinity rules Daniel Kral
2026-07-22  8:48 ` [PATCH ha-manager v3 02/16] rules: rename ambiguous argument nodes to cluster nodes Daniel Kral
2026-07-22  8:48 ` [PATCH ha-manager v3 03/16] hash-tools: use v5.36 and signatures in module Daniel Kral
2026-07-22  8:48 ` [PATCH ha-manager v3 04/16] rules: node affinity: implement negative node affinity rules Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 05/16] ui: ha: node affinity: handle empty node priority list string Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 06/16] ui: ha: node affinity: handle non-existent nodes Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 07/16] ui: ha: node affinity: do update node selection all at once Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 08/16] ui: ha: node affinity: commit node priority store " Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 09/16] ui: ha: node affinity: move node priority selector into separate component Daniel Kral
2026-07-22  8:48 ` Daniel Kral [this message]
2026-07-22  8:48 ` [PATCH manager v3 11/16] ui: ha: node affinity: allow setting affinity for node affinity rules Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 12/16] ui: ha: node affinity: do not send default node affinity rule values Daniel Kral
2026-07-22  8:48 ` [PATCH docs v3 13/16] ha-manager: rules: use the correct article for terms starting with HA Daniel Kral
2026-07-22  8:48 ` [PATCH docs v3 14/16] ha-manager: rules: improve resource affinity rule short description Daniel Kral
2026-07-22  8:48 ` [PATCH docs v3 15/16] ha-manager: rules: adapt rule configuration examples Daniel Kral
2026-07-22  8:48 ` [PATCH docs v3 16/16] ha-manager: rules: add negative node affinity rule descriptions Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722084824.108350-11-d.kral@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal