public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH-SERIES docs/ha-manager/manager v3 00/16] Negative Node Affinity Rules
Date: Wed, 22 Jul 2026 10:48:08 +0200	[thread overview]
Message-ID: <20260722084824.108350-1-d.kral@proxmox.com> (raw)

v2: https://lore.proxmox.com/pve-devel/20260602100226.180071-1-d.kral@proxmox.com/
RFC v1: https://lore.proxmox.com/pve-devel/20251219133643.295514-1-d.kral@proxmox.com/

Thanks to @David for reviewing the patches in v2!

changes since v2:
- rebase on master
- add ha patch to convert PVE::HA::HashTools to use v5.36
- make set_difference() use signatures instead of prototypes
- add ui patch to handle empty node priority list string
- use store.{begin,end}Update() when setting node priorities
- clean up NodePrioritySelector component
- fix being able to send node priorities again (forgot adding the change
  listener on the proxmoxintegerfield in the priority column)
- add link between config value and descriptive text for node affinity and
  resource affinity rules in the web interface
- fix some typos in the doc patches


For larger HA clusters, specifying the nodes in simple* node affinity
rules as opt-out (negative) instead of opt-in (positive) can make the
rule set easier to follow and implement by users.

* simple = without priority groups


Negative node affinity rules can be declared manually in the rules.cfg
now with these two small patches:


node-affinity: ha-rule-name
	affinity negative
	nodes node1,node2
	resources vm:100,vm:101

In a cluster with node1,...,node5 this will result in the identical
positive node affinity rule:

node-affinity: ha-rule-name-dual
	affinity positive
	nodes node3,node4,node5
	resources vm:100,vm:101


The web interface does allow switching between positive and negative node
affinity rules at any time to make it convenient when one representation is
easier to read than the other. The node selection is just the complement set
and the node priority class field is not shown for negative node affinity
rules.


ha-manager:

Daniel Kral (4):
  rules: node affinity: add affinity property to node affinity rules
  rules: rename ambiguous argument nodes to cluster nodes
  hash-tools: use v5.36 and signatures in module
  rules: node affinity: implement negative node affinity rules

 src/PVE/HA/Groups.pm                          |   1 +
 src/PVE/HA/HashTools.pm                       |  33 ++--
 src/PVE/HA/Rules.pm                           |  39 ++--
 src/PVE/HA/Rules/NodeAffinity.pm              | 171 +++++++++++++++++-
 src/PVE/HA/Rules/ResourceAffinity.pm          |  17 +-
 .../defaults-for-node-affinity-rules.cfg      |  23 ++-
 ...efaults-for-node-affinity-rules.cfg.expect |  62 ++++++-
 ...nt-node-resource-affinity-rules.cfg.expect |   3 +
 ...effective-negative-node-affinity-rules.cfg |  12 ++
 ...ve-negative-node-affinity-rules.cfg.expect |  17 ++
 ...ositive-resource-affinity-rules.cfg.expect |   4 +
 ...ty-with-resource-affinity-rules.cfg.expect |   2 +
 ...rce-refs-in-node-affinity-rules.cfg.expect |   3 +
 ...iority-in-negative-node-affinity-rules.cfg |  11 ++
 ...in-negative-node-affinity-rules.cfg.expect |  45 +++++
 15 files changed, 399 insertions(+), 44 deletions(-)
 create mode 100644 src/test/rules_cfgs/ineffective-negative-node-affinity-rules.cfg
 create mode 100644 src/test/rules_cfgs/ineffective-negative-node-affinity-rules.cfg.expect
 create mode 100644 src/test/rules_cfgs/node-priority-in-negative-node-affinity-rules.cfg
 create mode 100644 src/test/rules_cfgs/node-priority-in-negative-node-affinity-rules.cfg.expect


manager:

Daniel Kral (8):
  ui: ha: node affinity: handle empty node priority list string
  ui: ha: node affinity: handle non-existent nodes
  ui: ha: node affinity: do update node selection all at once
  ui: ha: node affinity: commit node priority store all at once
  ui: ha: node affinity: move node priority selector into separate
    component
  ui: ha: resource affinity: add hint for affinity type config value
  ui: ha: node affinity: allow setting affinity for node affinity rules
  ui: ha: node affinity: do not send default node affinity rule values

 www/manager6/Makefile                         |   1 +
 www/manager6/ha/NodePrioritySelector.js       | 237 ++++++++++++++++++
 www/manager6/ha/rules/NodeAffinityRuleEdit.js | 157 +++---------
 www/manager6/ha/rules/NodeAffinityRules.js    |   5 +
 .../ha/rules/ResourceAffinityRuleEdit.js      |   4 +-
 5 files changed, 284 insertions(+), 120 deletions(-)
 create mode 100644 www/manager6/ha/NodePrioritySelector.js


docs:

Daniel Kral (4):
  ha-manager: rules: use the correct article for terms starting with HA
  ha-manager: rules: improve resource affinity rule short description
  ha-manager: rules: adapt rule configuration examples
  ha-manager: rules: add negative node affinity rule descriptions

 ha-manager.adoc | 77 ++++++++++++++++++++++++++++++++++---------------
 1 file changed, 53 insertions(+), 24 deletions(-)


Summary over all repositories:
  21 files changed, 736 insertions(+), 188 deletions(-)

-- 
Generated by murpp 0.12.0




             reply	other threads:[~2026-07-22  8:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  8:48 Daniel Kral [this message]
2026-07-22  8:48 ` [PATCH ha-manager v3 01/16] rules: node affinity: add affinity property to node affinity rules Daniel Kral
2026-07-22  8:48 ` [PATCH ha-manager v3 02/16] rules: rename ambiguous argument nodes to cluster nodes Daniel Kral
2026-07-22  8:48 ` [PATCH ha-manager v3 03/16] hash-tools: use v5.36 and signatures in module Daniel Kral
2026-07-22  8:48 ` [PATCH ha-manager v3 04/16] rules: node affinity: implement negative node affinity rules Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 05/16] ui: ha: node affinity: handle empty node priority list string Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 06/16] ui: ha: node affinity: handle non-existent nodes Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 07/16] ui: ha: node affinity: do update node selection all at once Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 08/16] ui: ha: node affinity: commit node priority store " Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 09/16] ui: ha: node affinity: move node priority selector into separate component Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 10/16] ui: ha: resource affinity: add hint for affinity type config value Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 11/16] ui: ha: node affinity: allow setting affinity for node affinity rules Daniel Kral
2026-07-22  8:48 ` [PATCH manager v3 12/16] ui: ha: node affinity: do not send default node affinity rule values Daniel Kral
2026-07-22  8:48 ` [PATCH docs v3 13/16] ha-manager: rules: use the correct article for terms starting with HA Daniel Kral
2026-07-22  8:48 ` [PATCH docs v3 14/16] ha-manager: rules: improve resource affinity rule short description Daniel Kral
2026-07-22  8:48 ` [PATCH docs v3 15/16] ha-manager: rules: adapt rule configuration examples Daniel Kral
2026-07-22  8:48 ` [PATCH docs v3 16/16] ha-manager: rules: add negative node affinity rule descriptions Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722084824.108350-1-d.kral@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal