public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH installer] install: fix progress percent reporting when creating root and swap
Date: Fri, 17 Jul 2026 13:18:57 +0200	[thread overview]
Message-ID: <20260717111915.955612-1-c.heiss@proxmox.com> (raw)

Currently the progress reported when using the auto-installer (where it
is most noticeable) is:

  INFO: progress   0.0 % - cleanup root-disks
  INFO: progress   2.0 % - create partitions
  INFO: progress   3.0 % - create LVs
  INFO: progress   1.0 % - create swap space
  INFO: progress   1.1 % - creating root filesystems
  INFO: progress   5.0 % - creating root filesystem
  [..]

.. i.e. the progress can go backwards.

Fix it by aligning the two update_progress() calls with the others,
so that the progress is reported as originally intended:

  [..]
  INFO: progress   4.0 % - create swap space
  INFO: progress   4.5 % - creating root filesystems
  [..]

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 Proxmox/Install.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 788aca4..0387c6e 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -1006,12 +1006,12 @@ sub extract_data {
         }
 
         if ($swapfile) {
-            update_progress(0.04, 0, $maxper, "create swap space");
+            update_progress(0, 0.04, $maxper, "create swap space");
             syscmd("mkswap -f $swapfile") == 0
                 || die "unable to create swap space\n";
         }
 
-        update_progress(0.045, 0, $maxper, "creating root filesystems");
+        update_progress(0, 0.045, $maxper, "creating root filesystems");
 
         foreach my $di (@$bootdevinfo) {
             next if !$di->{esp};
-- 
2.54.0





             reply	other threads:[~2026-07-17 11:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 11:18 Christoph Heiss [this message]
2026-07-17 13:58 ` applied: [PATCH installer] install: fix progress percent reporting when creating root and swap Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717111915.955612-1-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal