From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 8AC1C1FF12C for ; Fri, 17 Jul 2026 13:19:55 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A77F621419; Fri, 17 Jul 2026 13:19:54 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Subject: [PATCH installer] install: fix progress percent reporting when creating root and swap Date: Fri, 17 Jul 2026 13:18:57 +0200 Message-ID: <20260717111915.955612-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784287140268 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: C35J6UMLNS6QCKJXBXRKXPYKGIX5WUJB X-Message-ID-Hash: C35J6UMLNS6QCKJXBXRKXPYKGIX5WUJB X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently the progress reported when using the auto-installer (where it is most noticeable) is: INFO: progress 0.0 % - cleanup root-disks INFO: progress 2.0 % - create partitions INFO: progress 3.0 % - create LVs INFO: progress 1.0 % - create swap space INFO: progress 1.1 % - creating root filesystems INFO: progress 5.0 % - creating root filesystem [..] .. i.e. the progress can go backwards. Fix it by aligning the two update_progress() calls with the others, so that the progress is reported as originally intended: [..] INFO: progress 4.0 % - create swap space INFO: progress 4.5 % - creating root filesystems [..] Signed-off-by: Christoph Heiss --- Proxmox/Install.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 788aca4..0387c6e 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -1006,12 +1006,12 @@ sub extract_data { } if ($swapfile) { - update_progress(0.04, 0, $maxper, "create swap space"); + update_progress(0, 0.04, $maxper, "create swap space"); syscmd("mkswap -f $swapfile") == 0 || die "unable to create swap space\n"; } - update_progress(0.045, 0, $maxper, "creating root filesystems"); + update_progress(0, 0.045, $maxper, "creating root filesystems"); foreach my $di (@$bootdevinfo) { next if !$di->{esp}; -- 2.54.0