public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH manager v3 2/2] ui: fabrics: skip unsupported IP properties on submit
Date: Wed, 15 Jul 2026 10:15:16 +0200	[thread overview]
Message-ID: <20260715081519.29721-3-l.sichert@proxmox.com> (raw)
In-Reply-To: <20260715081519.29721-1-l.sichert@proxmox.com>

The interface selector store is initialized from the node network API,
which includes existing IPv4 and IPv6 addresses as ip and ip6. Hiding an
IP column does not remove those fields from the selected record.

getValue() serializes the selected record data, so BGP unnumbered
interfaces could still submit stale ip and ip6 properties even though
BGP supports neither per-interface address. The backend then rejects the
property string with errors such as 'interfaces[0].ip: property is not
defined in schema'.

Skip ip and ip6 during serialization when the corresponding support flag
is disabled.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
Tested-by: Hannes Laimer <h.laimer@proxmox.com>
Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>
---
 www/manager6/sdn/fabrics/InterfacePanel.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js
index 95424bc0..08a53a34 100644
--- a/www/manager6/sdn/fabrics/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/InterfacePanel.js
@@ -178,7 +178,11 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
                     continue;
                 }
 
-                if (['type', 'isDisabled'].includes(key)) {
+                if (
+                    ['type', 'isDisabled'].includes(key) ||
+                    (key === 'ip' && !me.hasIpv4Support) ||
+                    (key === 'ip6' && !me.hasIpv6Support)
+                ) {
                     continue;
                 }
 
-- 
2.47.3





  parent reply	other threads:[~2026-07-15  8:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15  8:15 [PATCH manager v3 0/2] ui: fabrics: handle unsupported IP properties for BGP interfaces Lukas Sichert
2026-07-15  8:15 ` [PATCH manager v3 1/2] ui: fabrics: make IPv4 interface column optional Lukas Sichert
2026-07-15  8:15 ` Lukas Sichert [this message]
2026-07-15 12:24 ` applied: [PATCH manager v3 0/2] ui: fabrics: handle unsupported IP properties for BGP interfaces Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260715081519.29721-3-l.sichert@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal