From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 244721FF0E5 for ; Wed, 15 Jul 2026 10:15:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D1A01214B9; Wed, 15 Jul 2026 10:15:30 +0200 (CEST) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH manager v3 2/2] ui: fabrics: skip unsupported IP properties on submit Date: Wed, 15 Jul 2026 10:15:16 +0200 Message-ID: <20260715081519.29721-3-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260715081519.29721-1-l.sichert@proxmox.com> References: <20260715081519.29721-1-l.sichert@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784103308877 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.166 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ST567BBLVXREJD7CXB5WEPQZYDWBXGWQ X-Message-ID-Hash: ST567BBLVXREJD7CXB5WEPQZYDWBXGWQ X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The interface selector store is initialized from the node network API, which includes existing IPv4 and IPv6 addresses as ip and ip6. Hiding an IP column does not remove those fields from the selected record. getValue() serializes the selected record data, so BGP unnumbered interfaces could still submit stale ip and ip6 properties even though BGP supports neither per-interface address. The backend then rejects the property string with errors such as 'interfaces[0].ip: property is not defined in schema'. Skip ip and ip6 during serialization when the corresponding support flag is disabled. Signed-off-by: Lukas Sichert Tested-by: Hannes Laimer Reviewed-by: Hannes Laimer --- www/manager6/sdn/fabrics/InterfacePanel.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js index 95424bc0..08a53a34 100644 --- a/www/manager6/sdn/fabrics/InterfacePanel.js +++ b/www/manager6/sdn/fabrics/InterfacePanel.js @@ -178,7 +178,11 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', { continue; } - if (['type', 'isDisabled'].includes(key)) { + if ( + ['type', 'isDisabled'].includes(key) || + (key === 'ip' && !me.hasIpv4Support) || + (key === 'ip6' && !me.hasIpv6Support) + ) { continue; } -- 2.47.3