[PATCH v2 ceph 0/1] patches: drop patch disabling elastic_shared_blobs workaround

[PATCH v2 ceph 0/1] patches: drop patch disabling elastic_shared_blobs workaround

[Kefu Chai]

PR #65964 (commit 04d1d8ad575, Tentacle 20.2.1) fixed tracker#70390.
The workaround is no longer needed.

Changes since v1:
- rebased onto Tentacle 20.2.2; patch shifted from 0010 to 0009
  (py3dist was dropped in the 20.2.1 refresh), one fewer patch renumbered

Kefu Chai (1):
  patches: drop patch disabling elastic_shared_blobs workaround

 ...09-d-rules-disable-jaeger-telemetry.patch} |  0
 ...shared_blob-to-prevent-crashing-OSDs.patch | 33 -------------------
 ...p-legacy-init.d-ceph-script-anymore.patch} |  0
 ...port-by-making-NOTIFY_TYPES-in-py-m.patch} |  0
 ...e-on_progress-callbacks-to-prevent-.patch} |  0
 patches/series                                |  9 +++--
 6 files changed, 4 insertions(+), 38 deletions(-)
 rename patches/{0010-d-rules-disable-jaeger-telemetry.patch => 0009-d-rules-disable-jaeger-telemetry.patch} (100%)
 delete mode 100644 patches/0009-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
 rename patches/{0011-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch => 0010-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch} (100%)
 rename patches/{0012-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch => 0011-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch} (100%)
 rename patches/{0013-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch => 0012-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch} (100%)

-- 
2.47.3

[PATCH v2 ceph 1/1] patches: drop patch disabling elastic_shared_blobs workaround

[Kefu Chai]

The underlying crash (tracker#70390) was fixed upstream by PR #65964
(commit 04d1d8ad575), which is included in Tentacle 20.2.1. The
workaround of disabling bluestore_elastic_shared_blobs by default is
no longer needed.

[0] https://tracker.ceph.com/issues/70390
[1] https://github.com/ceph/ceph/pull/65964/

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 ...09-d-rules-disable-jaeger-telemetry.patch} |  0
 ...shared_blob-to-prevent-crashing-OSDs.patch | 33 -------------------
 ...p-legacy-init.d-ceph-script-anymore.patch} |  0
 ...port-by-making-NOTIFY_TYPES-in-py-m.patch} |  0
 ...e-on_progress-callbacks-to-prevent-.patch} |  0
 patches/series                                |  9 +++--
 6 files changed, 4 insertions(+), 38 deletions(-)
 rename patches/{0010-d-rules-disable-jaeger-telemetry.patch => 0009-d-rules-disable-jaeger-telemetry.patch} (100%)
 delete mode 100644 patches/0009-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
 rename patches/{0011-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch => 0010-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch} (100%)
 rename patches/{0012-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch => 0011-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch} (100%)
 rename patches/{0013-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch => 0012-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch} (100%)

diff --git a/patches/0010-d-rules-disable-jaeger-telemetry.patch b/patches/0009-d-rules-disable-jaeger-telemetry.patch
similarity index 100%
rename from patches/0010-d-rules-disable-jaeger-telemetry.patch
rename to patches/0009-d-rules-disable-jaeger-telemetry.patch
diff --git a/patches/0009-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch b/patches/0009-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
deleted file mode 100644
index 7180b2c4fc8..00000000000
--- a/patches/0009-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
+++ /dev/null
@@ -1,33 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Stoiko Ivanov <s.ivanov@proxmox.com>
-Date: Tue, 8 Apr 2025 12:13:10 +0200
-Subject: [PATCH] disable elastic_shared_blob to prevent crashing OSDs
-
-reported in our community forum and upstream:
-https://forum.proxmox.com/threads/164735/
-https://tracker.ceph.com/issues/70390
-https://github.com/ceph/ceph/pull/62724
-
-fix seems trivial, and the feature is quite new:
-https://ceph.io/assets/pdfs/events/2024/ceph-days-nyc/Diving%20Deep%20with%20Squid.pdf
-
-Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
-Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
-Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
----
- src/common/options/global.yaml.in | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/src/common/options/global.yaml.in b/src/common/options/global.yaml.in
-index da1ff5a1009..23e878fed65 100644
---- a/src/common/options/global.yaml.in
-+++ b/src/common/options/global.yaml.in
-@@ -5152,7 +5152,7 @@ options:
-   long_desc: Overwrites on snapped objects cause shared blob count to grow.
-     It has a very negative performance effect. When enabled shared blob count
-     is significantly reduced.
--  default: true
-+  default: false
-   flags:
-   - create
-   with_legacy: false
diff --git a/patches/0011-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch b/patches/0010-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
similarity index 100%
rename from patches/0011-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
rename to patches/0010-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
diff --git a/patches/0012-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch b/patches/0011-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
similarity index 100%
rename from patches/0012-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
rename to patches/0011-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
diff --git a/patches/0013-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch b/patches/0012-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
similarity index 100%
rename from patches/0013-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
rename to patches/0012-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
diff --git a/patches/series b/patches/series
index db38f90574a..383110a29e7 100644
--- a/patches/series
+++ b/patches/series
@@ -6,8 +6,7 @@
 0006-fix-compatibility-with-CPUs-not-supporting-SSE-4.1-i.patch
 0007-ceph-osd-postinst-do-not-always-reload-all-sysctl-se.patch
 0008-ceph-crash-change-order-of-client-names.patch
-0009-disable-elastic_shared_blob-to-prevent-crashing-OSDs.patch
-0010-d-rules-disable-jaeger-telemetry.patch
-0011-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
-0012-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
-0013-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
+0009-d-rules-disable-jaeger-telemetry.patch
+0010-debian-do-not-ship-legacy-init.d-ceph-script-anymore.patch
+0011-mgr-fix-module-import-by-making-NOTIFY_TYPES-in-py-m.patch
+0012-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch
-- 
2.47.3