public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu 2/2] d/{control,rules}: drop libsdl dependency
Date: Tue, 23 Jun 2026 17:29:25 +0200	[thread overview]
Message-ID: <20260623152955.406131-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260623152955.406131-1-f.ebner@proxmox.com>

The --disable-sdl flag is used during build, but the libsdl1.2-dev
build dependency was still present in d/control. That dependency
implicitly pulled in others. Drop the libsdl build dependency and be
explicit about the dependencies that were previously pulled in and the
features they auto-enabled, namely:
* libasound2-dev for CONFIG_AUDIO_ALSA
* libdrm-dev for HAVE_DRM_H (this is only used for linux-user, so could
  be dropped with a major release if desired)
* libglib2.0-dev (glib is widely used in the QEMU source code)
* libpulse-dev for CONFIG_AUDIO_PA
* libsndio-dev for CONFIG_AUDIO_SNDIO
* libxkbcommon-dev for qemu-keymap

The non-alsa audio libraries could be dropped with a major release if
desired. It seems that enabling support might have been done
unintentionally, because in debian/rules, --audio-drv-list="alsa" is
used. However, the backends are still auto-enabled when the libraries
are found, this list seems to be only used for the priorities for the
default audio backend.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/control | 7 ++++++-
 debian/rules   | 3 +++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 4c4b8fa4a1..ea9871d363 100644
--- a/debian/control
+++ b/debian/control
@@ -6,13 +6,16 @@ Build-Depends: debhelper-compat (= 13),
                check,
                libacl1-dev,
                libaio-dev,
+               libasound2-dev,
                libattr1-dev,
                libcap-ng-dev,
                libcurl4-gnutls-dev,
+               libdrm-dev,
                libepoxy-dev,
                libfdt-dev,
                libfuse3-dev,
                libgbm-dev,
+               libglib2.0-dev,
                libgnutls28-dev,
                libiscsi-dev (>= 1.12.0),
                libjpeg-dev,
@@ -22,10 +25,11 @@ Build-Depends: debhelper-compat (= 13),
                libpixman-1-dev,
                libpng-dev,
                libproxmox-backup-qemu0-dev (>= 1.3.0),
+               libpulse-dev,
                librbd-dev (>= 0.48),
-               libsdl1.2-dev,
                libseccomp-dev,
                libslirp-dev,
+               libsndio-dev,
                libspice-protocol-dev (>= 0.12.14~),
                libspice-server-dev (>= 0.14.0~),
                libsystemd-dev,
@@ -33,6 +37,7 @@ Build-Depends: debhelper-compat (= 13),
                libusb-1.0-0-dev (>= 1.0.17),
                libusbredirparser-dev (>= 0.6-2),
                libvirglrenderer-dev,
+               libxkbcommon-dev,
                libzstd-dev,
                meson,
                python3-minimal,
diff --git a/debian/rules b/debian/rules
index 76f3c9b661..a6b8745794 100755
--- a/debian/rules
+++ b/debian/rules
@@ -72,14 +72,17 @@ endif
 	    --enable-linux-io-uring \
 	    --enable-numa \
 	    --enable-opengl \
+	    --enable-pa \
 	    --enable-png \
 	    --enable-rbd \
 	    --enable-seccomp \
 	    --enable-slirp \
+	    --enable-sndio \
 	    --enable-spice \
 	    --enable-usb-redir \
 	    --enable-virglrenderer \
 	    --enable-virtfs \
+	    --enable-xkbcommon \
 	    --enable-zstd
 
 build: build-arch build-indep
-- 
2.47.3





  parent reply	other threads:[~2026-06-23 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23 15:29 [PATCH-SERIES qemu 0/2] fix #7722: restore PNG support and drop libsdl dependency Fiona Ebner
2026-06-23 15:29 ` [PATCH qemu 1/2] fix #7722: d/{control,rules}: restore PNG support Fiona Ebner
2026-06-23 15:29 ` Fiona Ebner [this message]
2026-06-24 14:49 ` [PATCH-SERIES qemu 0/2] fix #7722: restore PNG support and drop libsdl dependency Samuel Rufinatscha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260623152955.406131-3-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal