From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9B2F31FF146 for ; Tue, 23 Jun 2026 17:30:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5580C64F8; Tue, 23 Jun 2026 17:30:04 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu 2/2] d/{control,rules}: drop libsdl dependency Date: Tue, 23 Jun 2026 17:29:25 +0200 Message-ID: <20260623152955.406131-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260623152955.406131-1-f.ebner@proxmox.com> References: <20260623152955.406131-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782228587742 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ANUZRMTOO6CQMK3ZV6OW65JBPGGR2GP3 X-Message-ID-Hash: ANUZRMTOO6CQMK3ZV6OW65JBPGGR2GP3 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The --disable-sdl flag is used during build, but the libsdl1.2-dev build dependency was still present in d/control. That dependency implicitly pulled in others. Drop the libsdl build dependency and be explicit about the dependencies that were previously pulled in and the features they auto-enabled, namely: * libasound2-dev for CONFIG_AUDIO_ALSA * libdrm-dev for HAVE_DRM_H (this is only used for linux-user, so could be dropped with a major release if desired) * libglib2.0-dev (glib is widely used in the QEMU source code) * libpulse-dev for CONFIG_AUDIO_PA * libsndio-dev for CONFIG_AUDIO_SNDIO * libxkbcommon-dev for qemu-keymap The non-alsa audio libraries could be dropped with a major release if desired. It seems that enabling support might have been done unintentionally, because in debian/rules, --audio-drv-list="alsa" is used. However, the backends are still auto-enabled when the libraries are found, this list seems to be only used for the priorities for the default audio backend. Signed-off-by: Fiona Ebner --- debian/control | 7 ++++++- debian/rules | 3 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 4c4b8fa4a1..ea9871d363 100644 --- a/debian/control +++ b/debian/control @@ -6,13 +6,16 @@ Build-Depends: debhelper-compat (= 13), check, libacl1-dev, libaio-dev, + libasound2-dev, libattr1-dev, libcap-ng-dev, libcurl4-gnutls-dev, + libdrm-dev, libepoxy-dev, libfdt-dev, libfuse3-dev, libgbm-dev, + libglib2.0-dev, libgnutls28-dev, libiscsi-dev (>= 1.12.0), libjpeg-dev, @@ -22,10 +25,11 @@ Build-Depends: debhelper-compat (= 13), libpixman-1-dev, libpng-dev, libproxmox-backup-qemu0-dev (>= 1.3.0), + libpulse-dev, librbd-dev (>= 0.48), - libsdl1.2-dev, libseccomp-dev, libslirp-dev, + libsndio-dev, libspice-protocol-dev (>= 0.12.14~), libspice-server-dev (>= 0.14.0~), libsystemd-dev, @@ -33,6 +37,7 @@ Build-Depends: debhelper-compat (= 13), libusb-1.0-0-dev (>= 1.0.17), libusbredirparser-dev (>= 0.6-2), libvirglrenderer-dev, + libxkbcommon-dev, libzstd-dev, meson, python3-minimal, diff --git a/debian/rules b/debian/rules index 76f3c9b661..a6b8745794 100755 --- a/debian/rules +++ b/debian/rules @@ -72,14 +72,17 @@ endif --enable-linux-io-uring \ --enable-numa \ --enable-opengl \ + --enable-pa \ --enable-png \ --enable-rbd \ --enable-seccomp \ --enable-slirp \ + --enable-sndio \ --enable-spice \ --enable-usb-redir \ --enable-virglrenderer \ --enable-virtfs \ + --enable-xkbcommon \ --enable-zstd build: build-arch build-indep -- 2.47.3