From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager 1/1] fabrics: wireguard: node edit: use network selector
Date: Wed, 17 Jun 2026 15:58:13 +0200 [thread overview]
Message-ID: <20260617135814.427399-1-s.hanreich@proxmox.com> (raw)
For internal nodes, turn the endpoint form field into a network
selector that allows users to select IP addresses from a dropdown.
This makes the intention of the field clearer and also saves users
some typing since they can just select any configured IP on the node
without having to re-type it.
The defaultFocus property is set for the node edit window, to avoid
the network selector getting autofocused which leads to an ugly,
mispositioned combogrid getting rendered automatically when the edit
window gets rendered initially. Focus on the form can still be gained
by pressing Tab an additional time.
Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
.../sdn/fabrics/wireguard/NodeEdit.js | 38 ++++++++++++++++++-
1 file changed, 36 insertions(+), 2 deletions(-)
diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
index fe4639ade..f0d513162 100644
--- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
@@ -27,6 +27,8 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
},
},
+ defaultFocus: 'no',
+
additionalItems: [
{
xtype: 'proxmoxtextfield',
@@ -56,12 +58,37 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
allowBlank: false,
},
{
- xtype: 'proxmoxtextfield',
+ // endpoint field for internal nodes
+ xtype: 'proxmoxNetworkSelector',
+ reference: 'networkSelector',
fieldLabel: gettext('Endpoint'),
emptyText: gettext('Host that peers connect to'),
labelWidth: 120,
name: 'endpoint',
- allowBlank: false,
+ type: 'any_bridge',
+ valueField: 'address',
+ displayField: 'address',
+ autoSelect: false,
+ notFoundIsValid: true,
+ editable: true,
+ bind: {
+ allowBlank: '{current.isPveNode}',
+ hidden: '{!current.isPveNode}',
+ disabled: '{!current.isPveNode}',
+ },
+ },
+ {
+ // endpoint field for external nodes
+ xtype: 'proxmoxtextfield',
+ fieldLabel: gettext('Endpoint'),
+ emptyText: gettext('Host that peers connect to qqq'),
+ labelWidth: 120,
+ name: 'endpoint',
+ bind: {
+ allowBlank: '{!current.isPveNode}',
+ hidden: '{current.isPveNode}',
+ disabled: '{current.isPveNode}',
+ },
},
{
xtype: 'proxmoxtextfield',
@@ -167,6 +194,13 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
},
},
},
+ listeners: {
+ change: function (_this, newValue) {
+ if (me.getViewModel().get('current.isPveNode')) {
+ me.lookupReference('networkSelector').setNodename(newValue);
+ }
+ },
+ },
});
return config;
--
2.47.3
reply other threads:[~2026-06-17 13:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617135814.427399-1-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox