From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E99591FF14F for ; Wed, 17 Jun 2026 15:58:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 45E7737558; Wed, 17 Jun 2026 15:58:24 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 1/1] fabrics: wireguard: node edit: use network selector Date: Wed, 17 Jun 2026 15:58:13 +0200 Message-ID: <20260617135814.427399-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781704644234 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.595 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VWIJOD6IKSKLMFGXZEM5PQCZVJUHGPUV X-Message-ID-Hash: VWIJOD6IKSKLMFGXZEM5PQCZVJUHGPUV X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For internal nodes, turn the endpoint form field into a network selector that allows users to select IP addresses from a dropdown. This makes the intention of the field clearer and also saves users some typing since they can just select any configured IP on the node without having to re-type it. The defaultFocus property is set for the node edit window, to avoid the network selector getting autofocused which leads to an ugly, mispositioned combogrid getting rendered automatically when the edit window gets rendered initially. Focus on the form can still be gained by pressing Tab an additional time. Suggested-by: Dominik Csapak Signed-off-by: Stefan Hanreich --- .../sdn/fabrics/wireguard/NodeEdit.js | 38 ++++++++++++++++++- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js index fe4639ade..f0d513162 100644 --- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js +++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js @@ -27,6 +27,8 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { }, }, + defaultFocus: 'no', + additionalItems: [ { xtype: 'proxmoxtextfield', @@ -56,12 +58,37 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { allowBlank: false, }, { - xtype: 'proxmoxtextfield', + // endpoint field for internal nodes + xtype: 'proxmoxNetworkSelector', + reference: 'networkSelector', fieldLabel: gettext('Endpoint'), emptyText: gettext('Host that peers connect to'), labelWidth: 120, name: 'endpoint', - allowBlank: false, + type: 'any_bridge', + valueField: 'address', + displayField: 'address', + autoSelect: false, + notFoundIsValid: true, + editable: true, + bind: { + allowBlank: '{current.isPveNode}', + hidden: '{!current.isPveNode}', + disabled: '{!current.isPveNode}', + }, + }, + { + // endpoint field for external nodes + xtype: 'proxmoxtextfield', + fieldLabel: gettext('Endpoint'), + emptyText: gettext('Host that peers connect to qqq'), + labelWidth: 120, + name: 'endpoint', + bind: { + allowBlank: '{!current.isPveNode}', + hidden: '{current.isPveNode}', + disabled: '{current.isPveNode}', + }, }, { xtype: 'proxmoxtextfield', @@ -167,6 +194,13 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { }, }, }, + listeners: { + change: function (_this, newValue) { + if (me.getViewModel().get('current.isPveNode')) { + me.lookupReference('networkSelector').setNodename(newValue); + } + }, + }, }); return config; -- 2.47.3