* [PATCH manager v2] ui: fabrics: skip unsupported interface properties on submit
@ 2026-06-03 15:55 Lukas Sichert
2026-06-05 8:04 ` Hannes Laimer
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Sichert @ 2026-06-03 15:55 UTC (permalink / raw)
To: pve-devel; +Cc: Lukas Sichert
BGP unnumbered interfaces have neither IPv4 nor IPv6 addresses, but the
base interface panel always added the IPv4 column and only allowed child
panels to disable IPv6. This meant BGP still exposed an IPv4 field and
would also serialize existing IPv4 and IPv6 data from the node interface
record. When submitting such an interface, the backend rejects the
unsupported property with: 'format error interfaces[0].ip: property is
not defined in schema'
Add a 'hasIpv4Support' flag matching the existing IPv6 handling and use
both support flags to skip unsupported IP columns and properties during
serialization.
Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
www/manager6/sdn/fabrics/InterfacePanel.js | 37 ++++++++++++-------
.../sdn/fabrics/bgp/InterfacePanel.js | 11 +-----
2 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js
index f07e7859..e325340f 100644
--- a/www/manager6/sdn/fabrics/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/InterfacePanel.js
@@ -6,6 +6,7 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
nodeInterfaces: {},
+ hasIpv4Support: true,
hasIpv6Support: true,
selModel: {
@@ -59,19 +60,6 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
dataIndex: 'type',
flex: 1,
},
- {
- text: gettext('IPv4'),
- xtype: 'widgetcolumn',
- dataIndex: 'ip',
- flex: 1,
- widget: {
- xtype: 'proxmoxtextfield',
- isFormField: false,
- bind: {
- disabled: '{record.isDisabled}',
- },
- },
- },
],
additionalColumns: [],
@@ -112,6 +100,23 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
let columns = [...me.commonColumns];
+
+ if (me.hasIpv4Support) {
+ columns.push({
+ text: gettext('IPv4'),
+ xtype: 'widgetcolumn',
+ dataIndex: 'ip',
+ flex: 1,
+ widget: {
+ xtype: 'proxmoxtextfield',
+ isFormField: false,
+ bind: {
+ disabled: '{record.isDisabled}',
+ },
+ },
+ });
+ }
+
if (me.hasIpv6Support) {
columns.push({
text: gettext('IPv6'),
@@ -174,7 +179,11 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
continue;
}
- if (['type', 'isDisabled'].includes(key)) {
+ if (
+ ['type', 'isDisabled'].includes(key) ||
+ (key === 'ip' && !me.hasIpv4Support) ||
+ (key === 'ip6' && !me.hasIpv6Support)
+ ) {
continue;
}
diff --git a/www/manager6/sdn/fabrics/bgp/InterfacePanel.js b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
index c7ac7627..fd5e6f4b 100644
--- a/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
@@ -1,15 +1,6 @@
Ext.define('PVE.sdn.Fabric.Bgp.InterfacePanel', {
extend: 'PVE.sdn.Fabric.InterfacePanel',
+ hasIpv4Support: false,
hasIpv6Support: false,
-
- // BGP unnumbered interfaces have no IP - override commonColumns to
- // exclude the IP column that the base class defines.
- initComponent: function () {
- let me = this;
-
- me.commonColumns = me.commonColumns.filter((col) => col.dataIndex !== 'ip');
-
- me.callParent();
- },
});
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH manager v2] ui: fabrics: skip unsupported interface properties on submit
2026-06-03 15:55 [PATCH manager v2] ui: fabrics: skip unsupported interface properties on submit Lukas Sichert
@ 2026-06-05 8:04 ` Hannes Laimer
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Laimer @ 2026-06-05 8:04 UTC (permalink / raw)
To: Lukas Sichert, pve-devel
LGTM! could reproduce the problem, and this does work as advertised,
consider this:
Tested-by: Hannes Laimer <h.laimer@proxmox.com>
Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>
On 2026-06-03 17:54, Lukas Sichert wrote:
> BGP unnumbered interfaces have neither IPv4 nor IPv6 addresses, but the
> base interface panel always added the IPv4 column and only allowed child
> panels to disable IPv6. This meant BGP still exposed an IPv4 field and
> would also serialize existing IPv4 and IPv6 data from the node interface
> record. When submitting such an interface, the backend rejects the
> unsupported property with: 'format error interfaces[0].ip: property is
> not defined in schema'
>
> Add a 'hasIpv4Support' flag matching the existing IPv6 handling and use
> both support flags to skip unsupported IP columns and properties during
> serialization.
>
> Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
> ---
> www/manager6/sdn/fabrics/InterfacePanel.js | 37 ++++++++++++-------
> .../sdn/fabrics/bgp/InterfacePanel.js | 11 +-----
> 2 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js
> index f07e7859..e325340f 100644
> --- a/www/manager6/sdn/fabrics/InterfacePanel.js
> +++ b/www/manager6/sdn/fabrics/InterfacePanel.js
> @@ -6,6 +6,7 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
>
> nodeInterfaces: {},
>
> + hasIpv4Support: true,
> hasIpv6Support: true,
>
> selModel: {
> @@ -59,19 +60,6 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
> dataIndex: 'type',
> flex: 1,
> },
> - {
> - text: gettext('IPv4'),
> - xtype: 'widgetcolumn',
> - dataIndex: 'ip',
> - flex: 1,
> - widget: {
> - xtype: 'proxmoxtextfield',
> - isFormField: false,
> - bind: {
> - disabled: '{record.isDisabled}',
> - },
> - },
> - },
> ],
>
> additionalColumns: [],
> @@ -112,6 +100,23 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
>
> let columns = [...me.commonColumns];
>
> +
> + if (me.hasIpv4Support) {
> + columns.push({
> + text: gettext('IPv4'),
> + xtype: 'widgetcolumn',
> + dataIndex: 'ip',
> + flex: 1,
> + widget: {
> + xtype: 'proxmoxtextfield',
> + isFormField: false,
> + bind: {
> + disabled: '{record.isDisabled}',
> + },
> + },
> + });
> + }
> +
> if (me.hasIpv6Support) {
> columns.push({
> text: gettext('IPv6'),
> @@ -174,7 +179,11 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
> continue;
> }
>
> - if (['type', 'isDisabled'].includes(key)) {
> + if (
> + ['type', 'isDisabled'].includes(key) ||
> + (key === 'ip' && !me.hasIpv4Support) ||
> + (key === 'ip6' && !me.hasIpv6Support)
> + ) {
> continue;
> }
>
> diff --git a/www/manager6/sdn/fabrics/bgp/InterfacePanel.js b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
> index c7ac7627..fd5e6f4b 100644
> --- a/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
> +++ b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
> @@ -1,15 +1,6 @@
> Ext.define('PVE.sdn.Fabric.Bgp.InterfacePanel', {
> extend: 'PVE.sdn.Fabric.InterfacePanel',
>
> + hasIpv4Support: false,
> hasIpv6Support: false,
> -
> - // BGP unnumbered interfaces have no IP - override commonColumns to
> - // exclude the IP column that the base class defines.
> - initComponent: function () {
> - let me = this;
> -
> - me.commonColumns = me.commonColumns.filter((col) => col.dataIndex !== 'ip');
> -
> - me.callParent();
> - },
> });
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-05 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-03 15:55 [PATCH manager v2] ui: fabrics: skip unsupported interface properties on submit Lukas Sichert
2026-06-05 8:04 ` Hannes Laimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox