From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager 1/1] sdn: wireguard: dont disable name field on creating external node
Date: Fri, 15 May 2026 15:50:01 +0200 [thread overview]
Message-ID: <20260515135002.351323-1-s.hanreich@proxmox.com> (raw)
The logic for disabling the node_id field for external nodes was
wrong, leading to the name field being disable in the node creation
dialog. This prevents users from creating external WireGuard nodes.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
www/manager6/sdn/fabrics/wireguard/NodeEdit.js | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
index 69ef85c28..8393ee4a8 100644
--- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
@@ -18,6 +18,12 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
isPveNode: true,
},
},
+ formulas: {
+ disableNameField: function(get) {
+ let me = this;
+ return !me.getView().isCreate || get('current.isPveNode');
+ },
+ }
},
additionalItems: [
@@ -28,9 +34,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
name: 'node_id',
bind: {
hidden: '{current.isPveNode}',
- },
- cbind: {
- disabled: '{!isCreate}',
+ disabled: '{disableNameField}',
},
allowBlank: false,
},
--
2.47.3
next reply other threads:[~2026-05-15 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 13:50 Stefan Hanreich [this message]
2026-05-15 14:06 ` [PATCH pve-manager 1/1] sdn: wireguard: dont disable name field on creating external node Dominik Csapak
2026-05-15 14:24 ` Lukas Sichert
2026-05-15 14:58 ` Stefan Hanreich
2026-05-16 18:59 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515135002.351323-1-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox