From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 17B521FF14C for ; Fri, 15 May 2026 15:50:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 26051F35B; Fri, 15 May 2026 15:50:44 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 1/1] sdn: wireguard: dont disable name field on creating external node Date: Fri, 15 May 2026 15:50:01 +0200 Message-ID: <20260515135002.351323-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778853002956 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.602 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XX62FUJFRDG3ULYV364QWBHUEUA6SX6T X-Message-ID-Hash: XX62FUJFRDG3ULYV364QWBHUEUA6SX6T X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The logic for disabling the node_id field for external nodes was wrong, leading to the name field being disable in the node creation dialog. This prevents users from creating external WireGuard nodes. Signed-off-by: Stefan Hanreich --- www/manager6/sdn/fabrics/wireguard/NodeEdit.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js index 69ef85c28..8393ee4a8 100644 --- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js +++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js @@ -18,6 +18,12 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { isPveNode: true, }, }, + formulas: { + disableNameField: function(get) { + let me = this; + return !me.getView().isCreate || get('current.isPveNode'); + }, + } }, additionalItems: [ @@ -28,9 +34,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { name: 'node_id', bind: { hidden: '{current.isPveNode}', - }, - cbind: { - disabled: '{!isCreate}', + disabled: '{disableNameField}', }, allowBlank: false, }, -- 2.47.3