public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-network v6 4/9] sdn: fabrics: register bgp as a fabric protocol type
Date: Fri, 15 May 2026 12:24:55 +0200	[thread overview]
Message-ID: <20260515102500.216264-5-h.laimer@proxmox.com> (raw)
In-Reply-To: <20260515102500.216264-1-h.laimer@proxmox.com>

Add 'bgp' to the pve-sdn-fabric-protocol enum so it can be selected
when creating or updating fabric configurations via the API.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 src/PVE/Network/SDN/Fabrics.pm   | 63 +++++++++++++++++++++++++++++++-
 src/PVE/Network/SDN/RouteMaps.pm | 15 ++++++++
 2 files changed, 77 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Network/SDN/Fabrics.pm b/src/PVE/Network/SDN/Fabrics.pm
index fa76367..7e5f09b 100644
--- a/src/PVE/Network/SDN/Fabrics.pm
+++ b/src/PVE/Network/SDN/Fabrics.pm
@@ -51,7 +51,7 @@ PVE::JSONSchema::register_standard_option(
     {
         description => "Type of configuration entry in an SDN Fabric section config",
         type => 'string',
-        enum => ['openfabric', 'ospf', 'wireguard'],
+        enum => ['openfabric', 'ospf', 'wireguard', 'bgp'],
     },
 );
 
@@ -263,6 +263,21 @@ sub node_properties {
                     description => 'List of WireGuard network interfaces for this node.',
                     optional => 1,
                 },
+                {
+                    'instance-types' => ['bgp'],
+                    items => {
+                        type => 'string',
+                        format => {
+                            name => {
+                                type => 'string',
+                                format => 'pve-iface',
+                                description => 'Name of the network interface',
+                            },
+                        },
+                    },
+                    description => 'BGP network interface',
+                    optional => 1,
+                },
             ],
         },
         public_key => {
@@ -350,6 +365,15 @@ sub node_properties {
             type => 'array',
             'type-property' => 'protocol',
             oneOf => [
+                {
+                    type => 'array',
+                    'instance-types' => ['bgp'],
+                    items => {
+                        type => 'string',
+                        enum => ['interfaces', 'ip', 'ip6'],
+                    },
+                    optional => 1,
+                },
                 {
                     type => 'array',
                     'instance-types' => ['openfabric', 'ospf'],
@@ -478,6 +502,34 @@ sub fabric_properties {
                     },
                     optional => 1,
                 },
+                {
+                    type => 'array',
+                    'instance-types' => ['bgp'],
+                    items => {
+                        type => 'string',
+                        format => {
+                            source => {
+                                type => 'string',
+                                description =>
+                                    'The protocol from which to redistribute routes from.',
+                                enum => [
+                                    'connected',
+                                    'kernel',
+                                    'ospf',
+                                    'static',
+                                ],
+                            },
+                            'route-map' => {
+                                type => 'string',
+                                format => 'pve-sdn-route-map-id',
+                                description =>
+                                    'Route map to filter or transform redistributed routes from this source.',
+                                optional => 1,
+                            },
+                        },
+                    },
+                    optional => 1,
+                },
             ],
         },
     };
@@ -497,6 +549,15 @@ sub fabric_properties {
                     },
                     optional => 1,
                 },
+                {
+                    type => 'array',
+                    'instance-types' => ['bgp'],
+                    items => {
+                        type => 'string',
+                        enum => ['redistribute', 'route_filter', 'route_map_in', 'route_map_out'],
+                    },
+                    optional => 1,
+                },
                 {
                     type => 'array',
                     'instance-types' => ['ospf'],
diff --git a/src/PVE/Network/SDN/RouteMaps.pm b/src/PVE/Network/SDN/RouteMaps.pm
index c02a38f..71fa0e7 100644
--- a/src/PVE/Network/SDN/RouteMaps.pm
+++ b/src/PVE/Network/SDN/RouteMaps.pm
@@ -126,6 +126,21 @@ sub check_references {
                 if $controller->{'route-map-out'} eq $route_map_id;
         }
     }
+
+    my $fabrics = PVE::Network::SDN::Fabrics::config()->list_fabrics();
+    for my $fabric_id (keys $fabrics->%*) {
+        my $fabric = $fabrics->{$fabric_id};
+
+        if ($fabric->{route_map_in}) {
+            die "route map $route_map_id still referenced by fabric $fabric_id"
+                if $fabric->{route_map_in} eq $route_map_id;
+        }
+
+        if ($fabric->{route_map_out}) {
+            die "route map $route_map_id still referenced by fabric $fabric_id"
+                if $fabric->{route_map_out} eq $route_map_id;
+        }
+    }
 }
 
 sub route_map_properties {
-- 
2.47.3





  parent reply	other threads:[~2026-05-15 10:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 10:24 [PATCH docs/manager/network/proxmox{-ve-rs,-perl-rs} v6 0/9] sdn: add BGP fabric Hannes Laimer
2026-05-15 10:24 ` [PATCH proxmox-ve-rs v6 1/9] sdn: fabric: add BGP protocol support Hannes Laimer
2026-05-15 10:24 ` [PATCH proxmox-perl-rs v6 2/9] sdn: fabrics: add BGP config generation Hannes Laimer
2026-05-15 10:24 ` [PATCH proxmox-perl-rs v6 3/9] sdn: fabrics: add BGP status endpoints Hannes Laimer
2026-05-15 10:24 ` Hannes Laimer [this message]
2026-05-15 10:24 ` [PATCH pve-network v6 5/9] sdn: forbid BGP controller and BGP fabric coexistence Hannes Laimer
2026-05-15 10:24 ` [PATCH pve-network v6 6/9] sdn: evpn: support eBGP VTEPs over BGP fabric underlays Hannes Laimer
2026-05-15 10:24 ` [PATCH pve-network v6 7/9] test: evpn: add integration test for EVPN over BGP fabric Hannes Laimer
2026-05-15 10:24 ` [PATCH pve-manager v6 8/9] ui: sdn: add BGP fabric support Hannes Laimer
2026-05-15 10:25 ` [PATCH pve-docs v6 9/9] sdn: add bgp fabric section Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260515102500.216264-5-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal